search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Please add support for Kodi version 16 #322

Closed steezworld closed 7 years ago

steezworld commented 7 years ago

First off, thank you for continuing this project! GP was so good to me last year lol I'm very grateful to be able to use it again this year thanks to you guys! Can you please make the add-on work for Jarvis though? I'd be willing to contribute in some way. Thank you for your consideration!!

aqw commented 7 years ago

@steezworld We have no plans to add support for a deprecated release of Kodi. With each release, Kodi tweaks the APIs, and sometimes those changes are backwards incompatible. 16->17 was one of those releases.

If you are willing to do /all/ of the effort, I have no problem keeping your changes in a publicly available branch. But IMO, the effort you'd be making would be for very little (and temporary) gain.

Personally, I recommend upgrading to Kodi 17, as it will be followed by Kodi 18 and not 16. ;-)

---Alex

TweekDash commented 7 years ago

@steezworld I am toying around with using gamepass on Jarvis. I may have got it to work by editing the addon.xml, I updated the xbmc.python dependency version and the xbmc.gui dependency version to the following:

<import addon="xbmc.python" version="2.21.0"/>
<import addon="xbmc.gui" version="5.10.0"/>

after I installed the other dependencies manually as noted in the readme.md section and I pasted below it seemed to install the add-on ok and looks to be running.

Requests 2.x (http://mirrors.kodi.tv/addons/jarvis/script.module.requests/) m3u8 >= 0.2.10 (http://mirrors.kodi.tv/addons/jarvis/script.module.m3u8/) which needs iso8601 (http://mirrors.kodi.tv/addons/jarvis/script.module.iso8601/)

I am having some problems but I don't know if those are related to my installing on jarvis or if these are general bugs. I can't play archived games at the moment but I saw someone else post that same issue. I also don't see pre-season games but I am not sure yet if that's due to what I did or a general thing.

I'm going to install Krypton version and download the gamepass addon from the repo to see if I notice any differences with the problems I'm seeing, hope my advice/experience helps you.

EDIT: ok so i think whatever .zip file i had pulled was different because i installed the one from the repo on Krypton and it says International on the top and it shows the Preseason sections, the .zip version i installed for Jarvis said Domestic. I am still not able to play archived games so something must be wrong with that. I'll try to get pull a newer .zip and see if it gives me access to preseason section on Jarvis

darul86 commented 7 years ago

thanks for your effort tweekdash. i got an odroid u3 ( arm ) running gentoo linux and its hard way to get kodi 17 compiled and running. stuck with errors since some days. so it would be really to get it work for 16

TweekDash commented 7 years ago

update: I am pretty certain I had pulled an older copy at one point and that was the one I got working to an extent but it said "Domestic" at the top and didn't show access to the pre-season games.

I just pulled the latest gamepass version and made the same changes to the addon.xml and it installed onto Jarvis but when I went to launch the add-on I got the following error

11:55:05 T:6616 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

so I'm not sure what that means or where to go from there.

You could maybe try the older version I had got installed to see if that would work for you. Not sure if the playing of archived games will just get fixed or require a new add-on installation, if it's going to be fixed on the back-end it could be a workaround for you. If you need me to send you that version let me know, happy to try and help

TweekDash commented 7 years ago

yeah i checked the changelog on the first version i installed it was "2017.06.23 v0.10.2 -- Daunte Culpepper Edition"

sorry that probably won't fix anything for you. I guess I'm going to update all my systems to Krypton unless you know how to get past the error above