search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Remove "Final_Overtime" #357

Closed jbarry786 closed 6 years ago

jbarry786 commented 6 years ago

Hi guys,

is it possible to edit the code so that you do not get the information of "FINAL_OVERTIME" ? image

That is a huge spoiler not only for that particular game.... but for others as well, since if you only see "FINAL" in the others, you will know that they didn't go to overtime.

I would rather have no info whether the game was finished or not... over knowing it went to overtime.

Thank you

Displayel commented 6 years ago

also yesterday was a big mess, games were crashing back to the menu every 2-3 minutes, very frustrating yesterday, that was the first time this ever happened i believe

kaileu commented 6 years ago

Yes i noticed the same but i think it was a problem with Gamepass Servers. Sometime it works sometimes not. Some time every 2 Minutes then 40Minutes with no problem. It was really strange yesterday.

Mit freundlichen Grüßen Kai Leutner

Am 25.09.2017 um 09:10 schrieb Displayel notifications@github.com:

also yesterday was a big mess, games were crashing back to the menu every 2-3 minutes, very frustrating yesterday, that was the first time this ever happened i believe

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 6 years ago

jbarry786 is absolut right. Please remove this annoying spoilers or make them optional in the settings.

Thank you very much!

darul86 commented 6 years ago

thx for this great addon, but this issue sucks really hard.

i changed it by myself in default.py line 172 from "game_info = game['phase']" to "game_info = 'FINAL'"

ghost commented 6 years ago

darul86 thank you very much! I hope this change will be stitched into this fine addon.

aqw commented 6 years ago

Fixed by @pyrocumulus in #364, which is now merged.

Closing.