search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Gameinfo - mask FINAL_OVERTIME as FINAL #364

Closed pyrocumulus closed 6 years ago

pyrocumulus commented 6 years ago

As reported in #357 since a couple of weeks the game info (when hiding game length) tells you whether or not a game went into overtime. Undesirable when you chose such spoilers.

This PR simply checks for FINAL_OVERTIME and resets it to FINAL if found, making all games present themselves as FINAL.

Code review remark: I could've gone with an if-else but this looked a lot cleaner, you immediately see what the code is doing here, only triggering when FINAL_OVERTIME is actually found.

aqw commented 6 years ago

@pyrocumulus Sorry for the /long/ delay on this. This would be a great patch to get merged. I agree with @kaileu that this would be best if connected with the setting to hide time duration. Any chance that you'd be interested in adding that?

---Alex

pyrocumulus commented 6 years ago

@aqw welcome back 👍

And of course I'd be able to do that. See the commit I've just made. I was under the impression that the game info text 'FINAL' and 'FINAL_OVERTIME' were only visible when the user was hiding the game length. But apparently it's always visible, so that check for that 'hide game length' setting is indeed valuable.

aqw commented 6 years ago

@pyrocumulus I can't say I'm /really/ back, as there's too many things in real life conflicting for my attention. But I will be around from time to time. Thankfully a few people have already stepped up, providing patches, so I have hope that the addon will still be ready this year. :-)

Thanks again for the patch and the quick update. Merged. :-)

---Alex