pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Login Issues #397

Closed 41john closed 2 years ago

41john commented 6 years ago

Hi guys, I run the Gamepass channel for Plex. Just wondering if you have been seeing some login issues recently with this addon?

Looks like the service is authenticating using Gigya now?

aqw commented 6 years ago

@41john I've been doing a lot of work recently with the pigskin lib, and I've be running into intermittent problems with their login. I'm not sure if I'm being temporarily banned for too many retries, if their service is having problems, or if they're making changes. But yeah, it's odd.

Have you dug into this at all?

41john commented 6 years ago

Glad it ain't just me, though sucks to have these issues at the start of the season!

I have looked at it a bit when I have had the small bit of time to do so. If you capture your web session when logging in on the gamepass site you will see that it now goes to a service provider gigya to auth and then auth's slightly differently afterwards to the gamepass api. I'm yet to fully work on providing a solution. Looking at what happens when it auth's with the gigya provider it seems doable to recreate this but could be tricky. I was able to POST to gigya and get a successful auth however I need to work out where one or two variables are coming from to make this a working solution

aqw commented 6 years ago

@41john They always break it, right about now. Very annoying.

I'm looking at the web app, and it's a little odd. I think they're just dropping this in, hard-coding it into the web-ui rather than returning this login target as part of their normal config API.

I don't have a ton of time either right now, but if I get it working, I'll be sure to give you a heads up. Otherwise, this will have to wait a few days for me.

---Alex

aqw commented 6 years ago

@kaileu No idea about the mobile app, but the web is (at least for now) using gigya. There's a flag for whether it funnels to gigya or not. Don't know if the old one is shutdown permanently now or what.

41john commented 6 years ago

I will test mobile this evening, I’m hoping this is an option. Will also test my Apple TV. Otherwise we need to get it working via gigya.

41john commented 6 years ago

Hope this helps!

https://github.com/41john/NFL.bundle/commit/bcb4eaaac7d55d0f4992a1469e2418916b21fc77#diff-82217e099791031aefeda6741e905cfdL179

aqw commented 6 years ago

@41john Interesting. Thanks for sharing this! Your GIGYA_AUTH was the key bit I was missing. I'm a bit miffed that they don't share it via their JSON API, but whatever.

I'll let you know once I've made the fix, and if I uncover anything else in the process. :-)

---Alex

41john commented 6 years ago

You are welcome, seems to work great in my Plex channel now.

aqw commented 6 years ago

@41john I can confirm that this works locally for me. I ran out of time, so it's not pushed yet (will happen Friday), but it does work.

Thanks again for for your help. :-)

aqw commented 6 years ago

@41john Just as FYI, I have implemented your fix in pigskin. aqw/pigskin@b9b9f947ec77304fcef2ee0ac18ac2299feaa7f0 My implementation is largely the same as yours. The main differences are that I chose to stick with password as the grant_type rather than switching to shield_authentication, and my acquisition of the gigaya API key should be a bit more resilient (urlparse would be the complete solution here, but it felt like overkill).

Thanks again for your help. :-)

---Alex

aqw commented 6 years ago

The fix has been cherry-picked in 6d84f4d896baac06a7a243abc7073af43e47db13

Closing

kaileu commented 6 years ago

I am still confused that i don‘t habe any login Problems 🤔 Its wierd.

aqw commented 6 years ago

@kaileu I'm confused that you're confused. Are you running the latest code? If so, you have the necessary fixes.

if you don't have the latest code, then perhaps Game Pass re-enabled the old auth method. They've been toggling the Gigya requirement on and off. I have no idea what the heck they're doing.

kaileu commented 6 years ago

no my code base was not touched since 3 weeks. odd behaviour maybe it is more a regional thing.

not to mention that gygia is against europe dsgvo because they have to tell if they switch login provider and transfer the whole login detail to another company....

Ghoschdi commented 6 years ago

The old version from the kodi repo (August 23rd) works for me, the new version from git not. Get tons of login errors. Only downside, i seem unable to play any live games as I cannot open the week 1 category since 10pm CET. https://github.com/aqw/xbmc-gamepass/issues/396

aqw commented 5 years ago

@Ghoschdi @kaileu Thanks for the info. Sounds like the authentication isn't uniform everywhere. I now of reports of only 2018.08.23 working for some people and only 2018.09.08 working for others.

So I think the logging really should be sniffing for access, and then trying different auth methods from there. I'll try to make these changes soon, so people can start testing them.

aqw commented 5 years ago

Ok, so I've taken a bit of a brute force approach to the authentication code. The code now does the following:

This "should" work for everyone. But I won't be surprised in the least if it all blows up.

Any and all testing of this is /much/ appreciated. :-)

tinzarian commented 5 years ago

Login seems ok now. I had login issues with both the repo version (0823) end the latest master. With these changes I can login again.

Edit: I may have spoken too soon. I can't play any content, Game pass or NFL Network

Log: http://ix.io/1mp6,

aqw commented 5 years ago

@tinzarian Fantastic. Thanks for the info. @Ghoschdi and @kaileu Does the latest code work for you too?

Ghoschdi commented 5 years ago

Sorry, abroad at the moment and can only test Sunday this week. That said, my big problem was not login but the issue of not being able to open the week 1 category. Should I create another issue Sunday if it happens again?


Von: Alex Waite notifications@github.com Gesendet: Tuesday, September 11, 2018 9:30:18 AM An: aqw/xbmc-gamepass Cc: Stefan Denz; Mention Betreff: Re: [aqw/xbmc-gamepass] Login Issues (#397)

@tinzarianhttps://github.com/tinzarian Fantastic. Thanks for the info. @Ghoschdihttps://github.com/Ghoschdi and @kaileuhttps://github.com/kaileu Does the latest code work for you too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/aqw/xbmc-gamepass/issues/397#issuecomment-420192025, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJ38TvFgrO8uccjehrXN-75_9reKMdZJks5uZ3SZgaJpZM4WY9F_.

aqw commented 5 years ago

@Ghoschdi No problem. :-)

Yeah, if you have problems with entering a week again, please do open an issue. I'll see if I can take a look at it then.

jm-duke commented 5 years ago

The 0823 version was working for me until yesterday evening. When logins started failing today, I upgraded to Git master. Login is ok again, but I can't stream any games. Only related error:

18:36:16.307 T:1155523328 ERROR: could not find GP tokens to refresh

I added some logging code in refresh_tokens(), the response from https://www.nflgamepass.com/api/user/oauth/token is:

{
  'validationErrors': None,
  'message': 'error_unauthorised',
  'code': 'UR_10006',
  'id': 'some long id',
  'httpStatusCode': 401
}

I tried the App and Website too, both work.

Cheers.

rschloeg commented 5 years ago

Pretty much the same for me. Today, I can not start a new stream and get the same error 20:37:39.150 T:1761604512 ERROR: could not find GP tokens to refresh I have the latest version installed. Yesterday it worked. Maybe the NFL did make change?

jm-duke commented 5 years ago

It seems logins are possible again with the 0823 version, so i downgraded and applied the fix discussed in #410 . Works for the time being.

Displayel commented 5 years ago

the login issues are back for me on kodi, anyone else having problems loging in ?

Ghoschdi commented 5 years ago

I have the newest master and it works flawless for me on Android TV. Are you guys trying to login to multiple devices or players, e.g. mobile besides your primary device? Or are you "hammering" the login? E.g. trying fast again and again? Because when i did that a while ago, i could not even login to the browser GP app for a while.

Displayel commented 5 years ago

well it used to work but without changing anything on the configuration its not working anymore, its not a problem to being logged in somewhere else because you can connect up to 5 times starting this season...when you say you use the latest version is it here from github or is it just the latest version via repo ?

Ghoschdi commented 5 years ago

Latest master (github), works really flawless. And good to know that 5 times thing, but it seems to be really bugged then. If i log into the webapp, i need to wait quite a while before i can login on Shield TV with the Kodi GP addon.

MiranDalic commented 5 years ago

I am new one trying to use this add on and have error failed_login. Is that latest version from kodi repository or from GitHub ? If it is from GitHub how to install it on SONY smart TV ? Or should I try previous version ?

Ghoschdi commented 5 years ago

Just download the latest master from here: https://github.com/aqw/xbmc-gamepass/archive/master.zip put it onto a USB or transfer it somehow to your system that has Kodi, jump into Kodi, go to addons, select install from zip and select the package you downloaded. It will update the plugin and then work out of the box

MiranDalic commented 5 years ago

Just download the latest master from here: https://github.com/aqw/xbmc-gamepass/archive/master.zip put it onto a USB or transfer it somehow to your system that has Kodi, jump into Kodi, go to addons, select install from zip and select the package you downloaded. It will update the plugin and then work out of the box

Installed and logon works, but "game video" does not work :/ "coach film" does not, so only I can start Condensed game and highlights :/

Ghoschdi commented 5 years ago

Installed and logon works, but "game video" does not work :/ "coach film" does not, so only I can start Condensed game and highlights :/

I just tested this with the SEA at DET game and all 4 formats work flawlessly. Do you use the inputstream adaptive version? If not, i would give it a shot.

MiranDalic commented 5 years ago

Installed and logon works, but "game video" does not work :/ "coach film" does not, so only I can start Condensed game and highlights :/

I just tested this with the SEA at DET game and all 4 formats work flawlessly. Do you use the inputstream adaptive version? If not, i would give it a shot.

By default was the best quality not adaptive. I did try it adaptive but nothing change. Maybe you have older version of Kodi ?

Ghoschdi commented 5 years ago

I have the last stable release of 17.6 from Play store and on Windows, both work w/o any issues and both using inputstream adaptive. Have you activated the Kodi addon for that before enabling it on the GP addon? Because you will not see any quality selection when you use it, so no to your first sentence.

MiranDalic commented 5 years ago

I have the last stable release of 17.6 from Play store and on Windows, both work w/o any issues and both using inputstream adaptive. Have you activated the Kodi addon for that before enabling it on the GP addon? Because you will not see any quality selection when you use it, so no to your first sentence.

I have the last stable release of 17.6 from Play store and on Windows, both work w/o any issues and both using inputstream adaptive. Have you activated the Kodi addon for that before enabling it on the GP addon? Because you will not see any quality selection when you use it, so no to your first sentence.

I saw those settings and was thinking that they enabled. IMO having odd logic to set on/off and I was thinking that they are set ON. Apparently they aren't... After they were set ON all works like charm. I would like to thank to all people who make this add on it is so much better to use and control Gamepass trough remote and smart TV instead NFL app trough smartphone. Also I would like to thank you for help too !

Ghoschdi commented 5 years ago

So in reverse that means that without inputstream adaptive playback of game & coach video is broken. Will test that later myself and if true, will open a new issue here.

jm-duke commented 2 years ago

Doing some clean-up and this issue report is really old, so I'm closing it.