pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Error when trying to start a stream #410

Closed rschloeg closed 2 years ago

rschloeg commented 5 years ago

Like already commented in #397 by atduke and me: Since Yesterday, I can not start a new stream and get an error message. The Kodi logfile shows the error message 20:37:39.150 T:1761604512 ERROR: could not find GP tokens to refresh I have the latest version installed. The day before it worked fine.

kodi.log

ttobsen commented 5 years ago

Same here. Neither Jets vs. Browns nor NFL Network is working.

SirScott13 commented 5 years ago

Same issue. My error says "Unexpected Error :( Please enable debugging for both the addon and Kodi and submit a bug report."

kaileu commented 5 years ago

My guess is its related to https://github.com/aqw/pigskin/pull/23

rschloeg commented 5 years ago

@kaileu As far as I understand you mean we should try the newest version of the pigskin library. But how can we install that one? Up to now pigskin is part of the gamepass package, but the newest build of that is much older than the newest version of pigskin.

kaileu commented 5 years ago

No i only send a pull request. Alex has to merge the code till its in the official package. You could look what i changed and change it in your addon.

Mit freundlichen Grüßen Kai

Am 21.09.2018 um 18:46 schrieb rschloeg notifications@github.com:

@kaileu As far as I understand you mean we should try the newest version of the pigskin library. But how can we install that one? Up to now pigskin is part of the gamepass package, but the newest build of that is much older than the newest version of pigskin.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Ghoschdi commented 5 years ago

Hi Kai,

thanks for this, but unfortunately just combining your changes with the latest Github version if the Game Pass addon does not fix the issue (at least for me)

kaileu commented 5 years ago

I am using still the old version which works for me:( I didn‘t have time at the moment to review all the changes from alex maybe there is also something else wrong

Ghoschdi commented 5 years ago

So you are saying you are using the old release and combined it with your tweaks? Will test that right away

Ghoschdi commented 5 years ago

I can approve. Grabbing the old repo version or the master from Kaileu's github here: https://github.com/kaileu/xbmc-gamepass + editing the \resources\lib\pigskin.py in the zip archive Line 349: vs_format = i.attrib['format'].lower() to vs_format = i.attrib['name'].lower() then installing it in Kodi via the install from zip will get the playback working again.

rschloeg commented 5 years ago

I can confirm that. It works for me, too. Thank you very much, @kaileu and @Ghoschdi ! The only difference for me was that in my pigskin.py the line to be changed was line 307. but luckily there is only one line in the script which fits to the description of @Ghoschdi

acrewe commented 5 years ago

The above initially worked for me, however after exiting Kodi and re-entering I am continually receiving the below error. Please can you advise if there's anything I can try. Thanks

11:22:57.599 T:7804 ERROR: EXCEPTION: Dialog not created. 11:22:57.727 T:7804 ERROR: Login Failed. 11:22:57.727 T:7804 DEBUG: .

acrewe commented 5 years ago

Ah.... after checking repo, master and older versions with and without the 'format' to 'name' fix and receiving the exact same ERROR: Login Failed on each. Refreshed my IP address; and it's allowed me to login again, so possibly a timing issue or it is an IP ban maybe.

jm-duke commented 5 years ago

I too can confirm that after downgrading to 2018.08.23 and implementing the fix provided by @kaileu, I can stream games again.

JimmyJones79 commented 5 years ago

I've tried editing the file on the old version, no luck, tried switching to the 9-8 version, no luck. I wish I had something more to offer than I'm running Kodi 17.6 on a fire TV v2. The add-on worked great on Sunday /Monday, Jets vs Browns was when it failed.

I would also like to extend a big thank you to the people that make this Add-on possible to exist. Been using it for 2 years now. I am not a programmer but have programmed enough to edit code.

fritsie82 commented 5 years ago

I can approve. Grabbing the old repo version or the master from Kaileu's github here: https://github.com/kaileu/xbmc-gamepass + editing the \resources\lib\pigskin.py in the zip archive Line 349: vs_format = i.attrib['format'].lower() to vs_format = i.attrib['name'].lower() then installing it in Kodi via the install from zip will get the playback working again.

Works here as well. Not sure what the line number was but found the said text and after installing the zip GamePass worked again on my Kodi.

Edited ZIP file can be found here https://ufile.io/puxho

JimmyJones79 commented 5 years ago

@fritsie thanks I'll give it a try and report back

JimmyJones79 commented 5 years ago

Ok I tried the master file and I get "failed_login" (the credentials are correct), when I update to 8/23 it logs on fine but when any video is selected it gives the "Unexpected error..." Message. @fritsie what version of Kodi are you running?

SirScott13 commented 5 years ago

I can approve. Grabbing the old repo version or the master from Kaileu's github here: https://github.com/kaileu/xbmc-gamepass + editing the \resources\lib\pigskin.py in the zip archive Line 349: vs_format = i.attrib['format'].lower() to vs_format = i.attrib['name'].lower() then installing it in Kodi via the install from zip will get the playback working again.

Works here as well. Not sure what the line number was but found the said text and after installing the zip GamePass worked again on my Kodi.

Edited ZIP file can be found here https://ufile.io/puxho

@fritsie82 This zip file is perfect. Thanks for the help.

JimmyJones79 commented 5 years ago

Are you guys doing anything other than, uninstalling game pass, then downloading the 8/23 zip, editing the pigskin.py file, re-zipping and installing the add-on via zipfile method? Could using Kodi 17.6 Android, ARM be affecting me? I'm at a loss.

SirScott13 commented 5 years ago

@JimmyJones79
All I did was download the Edited ZIP file that @fritsie82 posted. Then I installed that add-on via ZIP. Then when I opened GamePass, full functionality had returned.

Ghoschdi commented 5 years ago

The failed login problems seems to occur when you logged in to the service on another device or multiple times on the same one. I think they found out that last season you could watch GP on 3 separate devices with 1 account. I believe some of the fixes that @aqw has done in the newer versions address this, but break the functionality of the playback. So i recommend to log out of all devices, do as SirScott said and try in about 15 mins.

acrewe commented 5 years ago

Got mine working on 1st and 2nd Gen firesticks, so shouldn't be an android/arm issue. To circumvent the login error I was getting, I did have to reboot my router to force a refresh of my IP address as waiting/logging out of everything did not alleviate it.

Ghoschdi commented 5 years ago

I have a static IP address and can tell you, just logging out of everything and waiting long enough for all sessions to terminate does work.

That said, getting a new IP accelerates your efforts, sure

acrewe commented 5 years ago

Fair enough, I must have just been impatient

Ghoschdi commented 5 years ago

Fair enough, I must have just been impatient

I know that one! :)

JimmyJones79 commented 5 years ago

Well I uninstalled, then installed the Master file again. Loaded up fine and is now streaming the Jets browns game with no issue, sometimes I think the thing just likes messing with me because I didn't do anything different other than 12hrs passed from the last attempt. I'll keep my fingers crossed for kick off time today. Thanks for the help guys, it's appreciated. @Ghoschdi ip address timing certainly may of been the issue for me

Live Eagles vs Colts streaming fine.

TweekDash commented 5 years ago

Hoping someone can assist. I am having many problems and have tried multiple solutions. I was using the Master branch from https://github.com/aqw/xbmc-gamepass and was able to login but got the errors anytime I would try to start a stream. I went ahead and followed this thread and downloaded the updated file https://ufile.io/puxho which had the edited pigskin.py from Kaileu's master branch.

When I installed that file I could not login to the app at all looks to be like the login issues from #397 What I tried next was applying the change vs_format = i.attrib['format'].lower() to vs_format = i.attrib['name'].lower() here into the aqw master, the login lines used different variables, first I only replaced the ['format'] to ['name'] but that didn't fix is to then next I replaced the entire For vs from aqe with the For I from the updated kaileu version and I still can't play streams

Ghoschdi commented 5 years ago

Just sign out of all apps, use the zip file and give the sessions time to terminate. Then try to login again. Until aqw is back or someone from the team can figure out all the clashing changes, there is nothing else you can do (unless you are familiar with python yourself and debug/merge the versions)

jpieti commented 5 years ago

@fritsie82 zip file worked as a charm! Thank you very much! Also big thanks to people who develop and maintain this NFL game pass addon!

laufgas commented 5 years ago

What about people like me with Android TV? nothing works on Kodi with my Android TV device. Get an error: "Unexpected Error :( Please enable debugging for both the addon and Kodi and submit a bug report."

jpieti commented 5 years ago

Actually I'm using Android TV , too. The only challenge I had, was to figure out how to load the modified zip -file to my Android TV system. My solution was to use my WLAN, which has network hardrive connected. From there it was easy, just install addon from zip file (Kodi showed automatically my network harddrive) and it started work.

laufgas commented 5 years ago

@jpieti I don't get an error message now, but when I try to start NFL network or a game, I choose the quality of the stream but nothing happens.

laufgas commented 5 years ago

One more update: I managed to start Highlights & Condensed games. The rest (NFL Network, full games, coache's film & NFL network archive) dont work.

jpieti commented 5 years ago

@laufgas In my installation everything works: at least the stuff I need: the games and NFL Network live. Sorry, but I have no clue, why they don't work in your system.

jpieti commented 5 years ago

@laufgas I don't know, if this has something to do with this... probably not... but I have followed this tip, which helped me earlier:

  1. go to add-ons-my Addons
  2. VideoPlayer Input Stream
  3. Enable input Stream Adaptive
  4. Go to gamepass Settings-->display/Video
  5. Activate Input Stream Adaptive. This was because of this: https://forum.kodi.tv/showthread.php?tid=320450&pid=2768126#pid2768126

But like I said, I don't know, if this has anything to do with this.

kabukimurder commented 5 years ago

The fix worked for me one time, but after logging out(after a few days) i can't seen to log in again. Reinstalling doesn't seen to help either.. probably because the user settings are saved.

jpieti commented 5 years ago

Now I'm getting the 'login failed' error. In the log there's an error which says something like this: you're not allowed to login in from this server. I give up. I started to use built-in chromecast and NFL game pass App from my phone.

tommmlij commented 5 years ago

I never wrote a xbmc addon, but I could not accept that I am not able to watch Drew shredding the record or the shootout between Bortels and the new Uber-QB. So I used my limited knowledge of Python and the Debug Console of Chrome to fix this.

I don't know how robust this is, but it's working for me...

Changes: https://github.com/tommmlij/xbmc-gamepass/commit/f3cb73a5afa68f2f4bc62a2da9386c7efca44dfa

The zip can be found here: https://github.com/tommmlij/xbmc-gamepass/releases

Have fun and happy gameday.

aqw commented 5 years ago

@tommmlij Glad you got this working. I've left a few comments in your repo. If you can do some additional testing, I'll include your changes.

kaileu commented 5 years ago

If thats your opinion than please make a pull request instead of release an own version.

tommmlij commented 5 years ago

@kaileu That is not my opinion, but what I did to make that work for me. The changes are not tested thoroughly, so I made no pull request. But since the next game is in 11h I made a fork and wanted people to know and potentially make it work. Geeze...

jpieti commented 5 years ago

@tommmlij Thank you very much! Works great at least in my system!

aqw commented 5 years ago

I've pushed a version that ports over the latest auth code form pigskin, includes your changes to the post data for gigya auth, adds further guards against exceptions, and includes @kaileu's videoSource fix.

This /should/ work, though no guarantees.

Testing is most welcome.

jm-duke commented 5 years ago

Yup, I'm back in business. I installed master and can log-in and stream games again. Thanks to all who contributed!

Cheers!

kabukimurder commented 5 years ago

Master works great now. Thanks guys!

laufgas commented 5 years ago

Sorry but I'm abit confused. Which file should I download to test and see if it's working now?

ttobsen commented 5 years ago

Sorry but I'm abit confused. Which file should I download to test and see if it's working now?

I think @aqw means the content of the Master branch. You can easily download the Zip file for installation by choosing the master branch and download the Zip file from the "clone or download" button.

I can also confirm that Master is working smoothly. And I'm pretty sure that games are loading a lot faster now (1-2 seconds compared to felt 5+ seconds in the last versions).

Yattle190 commented 5 years ago

This worked for me too on multiple machines last night but this morning I had the same old "debugging" message when running a stream.

I cleared my cache in Kodi and now it is working again. So try clearing your cache if you are still having problems with the updated Master. Hope this helps someone.

hrym55 commented 5 years ago

Hi,

I loaded the current master branch and I'm able to login and start condensed and the highlight videos, but unfortunately not the actual game video. I'm allowed to select the bitrate and then nothing happens. In the log there is the following message:

kodi_short.txt

Ghoschdi commented 5 years ago

Working flawless for me on both live and replay. @hrym55: Can you switch to inputstream adaptive? Look at https://github.com/aqw/xbmc-gamepass/issues/410#issuecomment-425647963 for instructions