kneespan
commented
6 years ago Is this project dead? That would be very sad - I used this add-on for years.
Closed kneespan closed 6 years ago
kneespan
commented
6 years ago Is this project dead? That would be very sad - I used this add-on for years.
Ghoschdi
commented
6 years ago No, just download the latest master from github, install it via zip in Kodi, enable inputstream and it works like a charm.
aqw
commented
6 years ago Hey @kneespan This project is not dead, it's just that I don't have a lot of time.
I cannot reproduce your problem. If you want an immediate fix, you'll have to debug it yourself, or convince one of the other lurking devs. Otherwise, I can't promise much in the next 2 weeks.
---Alex
OnceUponALoop
commented
6 years ago @kneespan the debug logging for the add-on is currently broken, you'll need to add
<setting id="debug" value="true" /> to your add-on settings.xml file to get any output that can be used for debugging.
That's why the debugging issues hasn't been fixed yet, the add-on needs to be updated to anonymize the logs - reference #402 & #405
kneespan
commented
6 years ago First of all - thanks for a really great add-on !! And thanks for the inputs, guys.
I uninstalled everything, deleted all config, installed the latest master, enabled Input-stream. Unfortunately, the issue still exists as described:
Do you need additional debug log or something - how can I help? Is the debug log above inconclusive or incomplete? Do I need to insert the setting from the comment above and re-post a debug log? Thanks.
EDIT: I can confirm it is a Kodi with Libreelec issue. Tested on other Kodi installations and the add-on worked fine. Issue title edited accordingly.
OnceUponALoop
commented
6 years ago @kneespan you'll need to make the change from my last comment to get any useful log output - without that you're going to be shooting in the dark, the log you pasted in the first comment is just kodi boilerplate stuff with no log entries from gamepass.
kneespan
commented
6 years ago OK thank you @OnceUponALoop I will do that asap.
I have new results: I was able to reproduce the behavior on any Kodi installation with newest master and Inputstream enabled. The problem seems to occur only after exiting and re-entering the add-on. The first time after initially starting Kodi, the add-on works normally. After exiting the app and re-entering, the problem occurs on any installation of Kodi. On Windows after exiting Kodi and restarting Kodi, the add-on works again until exiting and re-entering the add-on. On Libreelec after restarting Libreelec, the add-on works again until exiting the add-on and re-entering the add-on.
kneespan
commented
6 years ago OK guys - I debugged it myself. The problem is here in pigskin:
def nfldate_to_datetime(self, nfldate, localize=False):
"""Return a datetime object from an NFL Game Pass date string.
Parameters
----------
nfldata : str
The DIVA config URL that you need parsed.
localize : bool
Whether the datetime object should be localized.
Returns
-------
datetime
A datetime object when successful, None otherwise.
"""
nfldate_format = '%Y-%m-%dT%H:%M:%S.%fZ'
try:
dt_utc = datetime.strptime(nfldate, nfldate_format)
except ValueError:
self.logger.error('unable to parse the nfldate string')
return None
if localize:
try:
return dt_utc.replace(tzinfo=timezone.utc).astimezone(tz=None)
except NameError: # Python 2.7
return self.utc_to_local(dt_utc)
except Exception:
self.logger.error('unable to localize the nfl datetime object')
return None
return dt_utcwhen called after exiting and re-entering the add-on, datetime seems to be undefined here:
dt_utc = datetime.strptime(nfldate, nfldate_format)
I'm not able to step INTO the function and the error is TypeError: "attribute of type 'NoneType' is not callable"
I cannot explain, why it is undefined - all parameters seem identical. Something with initializing pigskin that happens only the first time the add-on is started?
I found an old thread with the exact same problem: https://forum.kodi.tv/showthread.php?tid=112916
But unfortunately the workaround from there is not working. Any ideas? @aqw ;) Thanks.
OnceUponALoop
commented
6 years ago @kneespan awesome work man. I can confirm I've seen this exact issue but haven't been able to pin down a scenario that would replicate it and kinda shrugged it off as a result of my fork being a work in progress.
How are you triggering this behavior? Does it happen every time? I've tried to just exit a working session and re-enter and couldn't replicate it. Now that i have a remote debugger setup it should be easy enough to nail it down.
suikerchiller
commented
6 years ago Thanks for the work @kneespan, I have the exact same issue with my kodi/libreelec setup. It would be great if someone knows a workaround as I'm stuck with laptop streaming atm.
OnceUponALoop
commented
6 years ago @suikerchiller If it's this specific issue then it can be resolved by just restarting kodi - the only time i've seen it was when relaunching the app.
@kneespan have you been able to replicate it at all today? I've tried it 10 different ways and i can't seem to get it to trigger the issue.
What i've tried 1- Start GP, play any game 2- Exit GP 3- Open GP, click gamepass
I tried playing a video from my library in between and it didn't seem to affect anything.
The last time I saw this issue was on Thursday, I wonder if it only shows up between thurs and sunday before the whole game list populates. If you're seeing it today please let me know, it'll at least eliminate that possibility.
kneespan
commented
6 years ago @OnceUponALoop since the error only occurs on future games, the error occurs only until all games of the current week have been played. yes - today I still have the error. Tomorrow it will be gone for week 10.
OnceUponALoop
commented
6 years ago @kneespan thanks a bunch for the input, the forum post you linked to was the key, should've paid more attention to your post initially instead of banging my head against it. I couldn't replicate because it doesn't show with a remote debugger attached 😕
I submitted a pull request (#417) for it, it'll be available when @aqw merges it in.
I have the patched version from here: https://github.com/aqw/xbmc-gamepass/issues/410#issuecomment-423767878
On libreelec (raspberry). Fresh start in the morning - no hanging log in on other device or such. Game list for the current week doesn't show up. When i click the current week or future weeks I get an error. Past weeks show and play without problems.
Any other debug log needed?
Thank you.