search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Support Leia #423

Closed baardisk closed 3 years ago

baardisk commented 5 years ago

The current version won't install on Leia. I have made som small changes so that it is compatible.

aqw commented 5 years ago

Hey @baardisk

Thanks for the PR. I have two questions: 1) have you used the addon to watch games? Usually GamePass changes their API and thus breaks the addon every off-season. It would be a pleasant surprise if that's not the case (yet) this season. 2) do you want feedback on your PR, or would you rather I just make the needed changes and merge?

---Alex

baardisk commented 5 years ago

Hey @baardisk

Thanks for the PR. I have two questions:

  1. have you used the addon to watch games? Usually GamePass changes their API and thus breaks the addon every off-season. It would be a pleasant surprise if that's not the case (yet) this season.
  2. do you want feedback on your PR, or would you rather I just make the needed changes and merge?

---Alex

Hi @aqw ,

  1. Yes, I used your original version last year. I used it on Kodi on Android TV. But now that Kodi was updated on my TV it no longer worked. After these changes that I made, I've tried it both on my TV and on my computer where the addon launches and I am able to browse both upcoming and old games and NFL Network. With InputStream Adaptive the games run fine. There is some issues however without InputStream Adaptive. The streams mostly won't start. But that's another issue. Will look into it.

  2. You can just make the changes and merge if you want. Up to you.

I can try to help out with the addon when I can if you want, but I may need some pointers to get started.

kabukimurder commented 4 years ago

Great work @baardisk. Please make this merge happen @aqw

usphil commented 4 years ago

I used version 2019-07-01 on Leia LibreElec 9.0.3, now it works very well with replays, but buffering too much with live stream. I also used version 2018/09/08 on Krypton LibreElec 8.2.5, everything works smooth on both replays and Live Hope @baardisk or @aqw fix it soon for Leia. Thank you very much!

ChloeMarieTaylor76 commented 4 years ago

Working fine on my Nvidia Shield TV with leia 18.3. On demand works great, nfl network live working fine, no buffering issues as mentioned. Will watch a live game this weekend and report back if any issues. Working better than the official Samsung TV app too :)

dav-sap commented 3 years ago

@aqw if you are still checking this repo up, its working 2020 as well, and im using international version, only with inputstream adaptive though. so i would merge this PR as well, as its compatible for kodi 18