pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Kodi 19 #428

Closed whitesnuf closed 2 years ago

whitesnuf commented 3 years ago

Kodi was updated to Version 19. This plugin is marked as not compatible.

Is there a chance to make compatible to Kodi 19?

Regards, whitesnuf

jm-duke commented 3 years ago

Alex mentioned a while ago that it should be pretty straight forward.

I'm still running on Kodi 18, so I have to get my hands on a testing equipment with Kodi 19. Sooner or later, I'll need the Kodi 19 support myself, so let's see what I can come up with :)

jm-duke commented 3 years ago

Luckily, I had a good old Raspi2 lying around.

With some modifications to the code I was able to successfully install and run the addon on an alpha release of Kodi 19. Watching games works, at least the two I tested ;-).

NFL network ain't working at the moment, that one probably needs some extensive digging.

If you want to give it a shot, you may install the addon via zip from the matrix branch in my fork: https://github.com/jm-duke/xbmc-gamepass/tree/matrix

Cheers.

jm-duke commented 3 years ago

Update: NFL network is now working too

aqw commented 3 years ago

Hey Everyone,

Obviously I have not been active in this project for probably 2 years now. New job, new city, overseeing a new team has meant that that 24 hours aren't enough in a day (even with lockdown).

I've been sad about watching this addon slowly decay. There's a lot of potential in both it and pigskin.

I am /thrilled/ to see that @jm-duke has forked this repo and given it some much needed love.

@jm-duke if you and/or others are interested in maintaining this, I would be happy to open a dedicated issue to discuss the best way to hand things over. :-)

---Alex

kabukimurder commented 3 years ago

Great work @jm-duke!! 👏 👏 👏 Hopefully there's a way to make the fork more visible to people.

aqw commented 3 years ago

Hopefully there's a way to make the fork more visible to people.

That's the goal. :-)

jm-duke commented 3 years ago

Hey @aqw,

nice hearing from you again! Never thought about returning to hacking the addon and pigskin? ;-)

Hm, I don't know if my time budget permits investing an awful lot of time into coding. But I'm at least using it for ~6 months every year and my wife is thoroughly pissed if the addon ain't working. So motivation to keep it running is there :D.

@aqw if you'd like to fully retreat, maybe we should consider some sort of handover or shared approach. Support is welcome of course :)

Cheers, Duke.

aqw commented 3 years ago

Hey @jm-duke, :-)

It's less about a desire to step away and more accepting the reality that I don't have the time (sadly). I don't want to step away, but I also don't want the project to fail due to my lack of involvement, especially when there's interest by others to keep it alive.

I may find time in the future, and contribute again, but right now, I don't have the mental bandwidth to review PRs and determine if they're sane.

I have opened #429 to explore options. :-)

---Alex

aqw commented 3 years ago

The new organization has been created, and @jm-duke now has commit rights (and the ability to grants those rights to others too).

I assume that @jm-duke will push his fixes for Kodi 19 to this repo soon, which should improve the visibility. :-)

jm-duke commented 3 years ago

I pushed my matrix branch to this repository now, but won't merge it yet. I'll probably wait until the likes of LibreELEC and OSMC switch to and fully support Kodi 19.

jm-duke commented 3 years ago

I'm thinking about creating a PR to re-add the gamepass addon to the kodi repo for Matrix.

@whitesnuf have you been able to test the master branch? Is it working on your end?

whitesnuf commented 3 years ago

The matrix branch works for me. The master branch seems not to be updated yet.

kabukimurder commented 3 years ago

I tried the matrix branch on Kodi 19(android tv) and it works great. However i couldn't open the settings from the icon inside the app.. had to do it from the outside.

Also the regular non-inputstream option should probably be removed in the future since it's hasn't worked in a long time. Nothing new for matrix ofc.

jm-duke commented 3 years ago

Thanks for the feedback.

I had the settings icon working in a Kodi 19 Alpha release, on the nightly LibreELEC build I use now it ain't working either. I'll look into it.

And I probably should also take a look at the non-adaptive streams ;-)

Weserspucker commented 3 years ago

does anyone else have an error message when trying to start NFL network or other content?

ERROR: No active NFL Game Pass Europe subscription was found. ERROR: Previous line repeats 1 times. ERROR: _gp_auth: server response is invalid ERROR: Could not acquire GP tokensERROR: _gp_auth: server response is invalid

my subscription is active! and works with official apps and browser

kabukimurder commented 3 years ago

I also can't start streams from the addon anymore. I guess they have redone something in their API this offseason. They pushed an update to the android tv app yesterday also.

jm-duke commented 3 years ago

Diva added some API validation. Fix to master is pushed already. I'll apply some more code cleanups to the matrix branch and push a fix in a few minutes.

TweekDash commented 3 years ago

which branch should I be using for Kodi 19.1? I downloaded .zip of master branch but ran into error: "dependency on xbmc.python version 2.26.0 could not be satisfied"

jm-duke commented 3 years ago

@TweekDash please use the matrix branch

msmittag commented 3 years ago

Hey Guys,

sorry just trying to make sure I got it right - only a user and fan - no expert. I use a Raspberry Pi3 and the app that worked for two years (gamepass Europe) does no longer. So I will have to: Install Kodi 19 - saw it as a download-version on LibreElec website - is that OK? Install the app that jm-duke linked in his post of 2nd March

That should do it?

jm-duke commented 3 years ago

sorry just trying to make sure I got it right - only a user and fan - no expert. I use a Raspberry Pi3 and the app that worked for two years (gamepass Europe) does no longer. So I will have to: Install Kodi 19 - saw it as a download-version on LibreElec website - is that OK? Install the app that jm-duke linked in his post of 2nd March

Which Kodi version are you running? 18?

If that's the case, you can download the master branch zip and install it in Kodi.

msmittag commented 3 years ago

Yes, running Kodi 18 - will try to install master branch zip.

Thanks!

jm-duke commented 2 years ago

Merged the matrix branch into master, closing this issue now.