search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Fixed bitrate streams fail to play #437

Closed jm-duke closed 1 year ago

jm-duke commented 2 years ago

[...] Also the regular non-inputstream option should probably be removed in the future since it's hasn't worked in a long time. Nothing new for matrix ofc.

Originally posted by @kabukimurder in https://github.com/pigskin/kodi-gamepass/issues/428#issuecomment-801986550

jm-duke commented 2 years ago

It seems the content URLs the add-on generates are no longer valid. This needs some intense reverse engineering, most probably a winter task...

A workaround: Use Inputstream Adaptive, which just works fine.

jm-duke commented 2 years ago

Also: Probably can remove the bitrate choices in the settings dialog. It seems every game stream is encoded with different rates, so it's kinda useless to define fixed rates in the settings.

jm-duke commented 1 year ago

As this seems to be the major issue ppl are facing with the add-on right now, I'm thinking about elevating Inputstream Adaptive to the default streaming method.

So what to do with the fixed bitrate streams:

  1. Remove the functionality altogether
  2. Remove the bitrate settings and present a dialog for each stream to choose from

Created a branch, let's see where this goes...

jm-duke commented 1 year ago

It seems NFL Game Pass has gone all in on adaptive streaming (see e.g. https://support.nflgamepass.com/hc/en-gb/articles/360005287033-Can-I-adjust-the-video-quality-).

I removed the fixed bit rate code in the 437-fixed-bitrate-streams-fail-to-play branch and am testing now. On demand is streaming without issues, and the latest episode of Hard Knocks on NFL Network was fine too ;-)

Going to test live streaming on the weekend. If that's fine too, I'll merge to master.

jm-duke commented 1 year ago

Merged the branch, fixed bit rate streams are history. Adaptive streaming is default now.