search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Settings dialog cannot be opened from inside the app #438

Closed jm-duke closed 1 year ago

jm-duke commented 2 years ago

[...]

However i couldn't open the settings from the icon inside the app.. had to do it from the outside.

Originally posted by @kabukimurder in https://github.com/pigskin/kodi-gamepass/issues/428#issuecomment-801986550

jm-duke commented 2 years ago

Need to update my testberry and test this with a more recent version of Kodi 19

TopRamenDom commented 1 year ago

We need to have our own credentials to use the add on correct ?

jm-duke commented 1 year ago

We need to have our own credentials to use the add on correct ?

Yup

ohhmyy commented 1 year ago

Hi @jm-duke . The problem that the settings cannot be opened inside the addon is in https://github.com/pigskin/kodi-gamepass/blob/master/resources/skins/Default/1080i/script-gamepass.xml at line 110: For my installation I had to change <onclick>Addon.OpenSettings(plugin.video.nfl.gamepass)</onclick> to <onclick>Addon.OpenSettings(script.video.nfl.gamepass)</onclick>

jm-duke commented 1 year ago

omg, good catch. I obviously forgot to update the skins when renaming stuff :D

Thanks!