search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

addon is not in the kodi repository #439

Closed shangri26199 closed 2 years ago

shangri26199 commented 3 years ago

as the title says, the addon is not listed in the kodi repository as of today.

I do think it is still installable via .zip packages. but this is not "the recommended way"

jm-duke commented 3 years ago

Yeah, I know. Getting an add-on into the official repository is a kinda lengthy process ;-)

I currently lack time to initiate this process, but it is on my todo list. Thanks for raising this issue, now it's tracked in here as well.

Cheers.

piejanssens commented 3 years ago

Can we help in any way?

We have some great CI setup in this shared community organisation of well maintained Kodi video add-ons to make releases to the Kodi repo a breeze. https://github.com/add-ons

BrainKingSoldier commented 2 years ago

as the title says, the addon is not listed in the kodi repository as of today.

I do think it is still installable via .zip packages. but this is not "the recommended way"

Where do I get a ZIP package nowadays? I'm just a simple non-programmer gamepass subscriber :D

piejanssens commented 2 years ago

https://github.com/pigskin/kodi-gamepass/archive/refs/heads/master.zip

jm-duke commented 2 years ago

Can we help in any way?

We have some great CI setup in this shared community organisation of well maintained Kodi video add-ons to make releases to the Kodi repo a breeze. https://github.com/add-ons

Oops, I totally missed that one...

I wouldn't call this add-on well maintained, but I'll absolutely check out your project, thanks!

BrainKingSoldier commented 2 years ago

thanks buddy

On Mon, Nov 15, 2021 at 11:54 AM Pieter Janssens @.***> wrote:

https://github.com/pigskin/kodi-gamepass/archive/refs/heads/master.zip

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pigskin/kodi-gamepass/issues/439#issuecomment-968769962, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQ5VMR6MKE3EEGQQNIPJJ3UMDRGZANCNFSM5D346LYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

piejanssens commented 2 years ago

@jm-duke Even without migrating to the other organisation, can I offer some help to maintain this add-on and get a new version in the Kodi repo?

jm-duke commented 2 years ago

I'll tackle this one after this season, life should be quieter in Q2.

Cheers.

jm-duke commented 2 years ago

https://github.com/xbmc/repo-scripts/pull/2306 created.

@aqw : Can you please add a comment to the PR giving me the permission to submit the gamepass addon?

They asked for it before:

It seems you are not the dev that submitted the most recent version (https://github.com/xbmc/repo-plugins/commit/45f49b15205ccfc052871e28c84d45919b6d30aa). So you will need to ask permisson from him/her before we will accept this PR.

aqw commented 2 years ago

Thanks for the ping. I have commented in the upstream PR.

If anything else comes up, let me know. :-)

Good luck with the season!

jm-duke commented 2 years ago

Awesome, thank you :)

Brandon1212b commented 2 years ago

https://github.com/pigskin/kodi-gamepass/archive/refs/heads/master.zip

Is this link still the best way to download? Is there a repo for this?

jm-duke commented 2 years ago

Yes, it still is. I submitted a request to add it to the official repository, but this request is still pending.

Brandon1212b commented 2 years ago

Awesome, thank you for the update

jm-duke commented 2 years ago

If you install from the master branch, please ensure that the inputstream.adaptive addon is also installed and enabled in Kodi. And please enable "Use inputstream adaptive" in the Kodi Gamepass addon settings, fixed bitrate playback is no longer supported, see #437 for details

Brandon1212b commented 2 years ago

I installed this version but I am having issues getting the NFL Network section to work. Is this the most updated one or would https://github.com/pigskin/pigskin be better?

Edit: to clarify. I am able to load NFL GamePass international and replay some of the preseason games or last years games. When I click on the right hand section for NFL Network it is just blank

jm-duke commented 2 years ago

No, https://github.com/pigskin/pigskin is a big rewrite, which most probably won't work at all. I'm not sure, if this rewrite will ever be finished tbh ;-)

NFL Network usually takes quite a while to load, how long did you wait? Can you enable debug logging, access NFL Network again and upload the log?

Brandon1212b commented 2 years ago

That was it. I was just being too impatient. I tried again and it showed up after 30 seconds. Thanks again @jm-duke for being so helpful.

jm-duke commented 2 years ago

Great, thanks for the feedback!

@Brandon1212b out of curiosity, would you mind sharing where you're located? I just would like to know, where this add-on can be used nowadays.

Brandon1212b commented 2 years ago

I am located in MD USA, using VPN

jm-duke commented 2 years ago

PR was merged by the Kodi team, the add-on is officially back ;-)