search

pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Plugin stopped working ( TypeError: string indices must be integers) #450

Closed AleXSR700 closed 1 year ago

AleXSR700 commented 1 year ago

Hello,

is the plugin working for anybody at the moment?

I am getting error messages. Login etc. is correct. I can stream from the Android NFL app.

https://controlc.com/7c92d092

Thank you Alex

jm-duke commented 1 year ago

Yeah, same here.

Something's changed in the API, no idea yet what and why. The add-on fails to retrieve stream content URLs for the chromecast stream type used so far, hls is still working though...

jm-duke commented 1 year ago

Please try https://github.com/pigskin/kodi-gamepass/commit/6e25910659c15710117997c6bd119ec5712817e1 and see, if that works for you

ohhmyy commented 1 year ago

The workaround works for me. The stream now starts again. Thank you very much for this. However, the highest resolution is now 1600x900. Wasn't it 1920x1080 before or do I remember that wrong? grafik

AleXSR700 commented 1 year ago

https://support.nflgamepass.com/hc/en-gb/articles/360005287033-Can-I-adjust-the-video-quality-#:~:text=Up%20to%201280x720px%20at%204.5,only%20for%20Chromecast%20and%20AppleTV

Depends on the stream, afaik.

Edit: +1 working

jm-duke commented 1 year ago

The workaround seems to be working fine, but what bugs me is that two out of three streaming contents fail. If NFL Gamepass decides to change the API for the single remaining stream, we're fucked. I hope I can find some time in the near future to reverse engineer the changes required to the content retrieval logic.

jm-duke commented 1 year ago

Well, had to do a bit too much Python coding in the last months, so I kinda was fed up with scripting and didn't have time or the will to look into this in more detail.

Gonna close this bug for now and will maybe pick it up at a later date.