pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
123 stars 83 forks source link

Feature request: Show date (or weekday) of game #452

Closed AleXSR700 closed 1 year ago

AleXSR700 commented 1 year ago

Hello, I am not even sure if this information is available but if it is: would it be possible to show either the date or weekday of the games?

Background: sometimes one does not know which game is the Thursday night game(s) oder Sunday/Monday or the Saturday games. Since they are not part of Redzone, it can happen that Redzone will spoiler them right at the beginning because you thought the game(s) were on Sunday ^^

jm-duke commented 1 year ago

Show the date and/or weekday where exactly? In Gamepass' game day lists? Or in NFL Network stuff, since you mentioned Redzone?

AleXSR700 commented 1 year ago

In Gamepass's gane day list. Each week has a list of games and right now it is impossible to tell which was the Monday Night game or the Thursday or which was early window or late window. So ideally, each game would show date and time of kick off.

jm-duke commented 1 year ago

Hm, that's not there? :) Man, season is over and I totally have no idea anymore, what the add-on looks like :rofl:

I'll check and play with adding some additional info. Need to look, if this fucks up the UI though.

AleXSR700 commented 1 year ago

If you have access to the data, the UI should be just fine. More than enough space underneath the "Final".

20230519_232927

P.S.: Please do not add end time or force game length. Otherwise we will know if it goes into overtime :)

AleXSR700 commented 1 year ago

It took me a few tries but I think I now got it working properly.

https://github.com/pigskin/kodi-gamepass/pull/454

I did not add translations (only English at the moment). I/you can of course add if necessary.

image image

P.S.: If game length is shown then game date is not (not enough space for both without it looking weird). SO I made the two settings conditional upon each other.

jm-duke commented 1 year ago

PR #454 merged