pigskin / kodi-gamepass

NFL Game Pass add-on for Kodi
Other
122 stars 83 forks source link

Unable to play 2014 HoF game #87

Closed fryingfish closed 10 years ago

fryingfish commented 10 years ago

Hi,

I'm trying to play last night's HoF game but keep getting this error: 09:12:29 T:2595222608 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

It suggests to me that its unable to find the stream, but I can play it directly from the website. Is is possible the way this seasons games are being referenced has changed? I tested I could load any game from 2013 and they all played fine, additionally NFL network live still works fine.

ChristofDC commented 10 years ago

I have this issue as well. When I want to start the HoF game, it's stuck on "working". I run RaspBmc and when I reboot my raspberry pi because it's stuck on working the addon is completely deleted and I have to reinstall it so I don't have a log file. All of the older games work so it's just the HoF game.

aqw commented 10 years ago

Yeah, I expected they'd change stuff for the 2014 season. The manifest is different, and they're returning some encryption info for the streams. I'm looking into this.

---Alex

BaumSchorle commented 10 years ago

@Alexqw this sucks, now the guessing game starts all over again. Seems like they changed their file structure on the servers. Have you found the m3u8 files? It's stupid they don't support 4.5 Mbits on the ipad, cause the publishpoint solution would be the nicest way to prevent all this guessing. :-/

aqw commented 10 years ago

I just pushed a fix, but it's untested. Can you give it a try?

If this doesn't work, then the fix depends on @BaumSchorle's work in #66.

---Alex

aqw commented 10 years ago

@BaumSchorle Really? Because archived games still seem to work for me. This looked to be a logic fail, since they use the "IsLive" tag to denote that it's a publishpoint stream, rather than an indicator that the game is actually Live. If my fix is correct, the game would have played correctly while it was Live, but not in this weird limbo period where it's marked as "Live", but actually isn't. This period usually last for a day or two.

---Alex

BaumSchorle commented 10 years ago

@Alexqw hm... at least the manifest looks different, but you could be right. I got up this night to test the live stream logic and it worked like a charm. I was able to watch the live game.

So this really could solve the issue, anyway the publishpoint logic would be the nicest but the bitrates are a killer criteria for this.

aqw commented 10 years ago

Yeah, more and more I'm thinking unifying everything under publish point would be the best solution. The bitrates are the only thing blocking this. I wonder if there's some magical user agent that gives us the best bitrates...

redhell commented 10 years ago

I watched it live with the latest build and it worked very well.

BaumSchorle commented 10 years ago

@Alexqw have you ever checked if they use the publishpoint in their flash plugin? I don't think so, but it would be cool. As far as I know and found out till now, the ipad support the best bitrates with 3.0 Mbits, which is my preferred setting. I didn't see much difference between 3.0 Mbits and 4.5 Mbits, it's not perfect HD quality as they only support 30fps anyway. ;)

fryingfish commented 10 years ago

Ok, so now with your current fix Alex it will "load", but it is trying to load the live stream, so just shows the "The game has ended" screen.

aqw commented 10 years ago

@BaumSchorle Yes they use publishpoint in the Flash plugin, but traditionally only for Live content (Games, RedZone, and NFL Network Live).

@fryingfish Hmm. Ok... so we need to determine how to seek to that spot. They're returning that info in the manifest. I'll see what I can find.

---Alex

BaumSchorle commented 10 years ago

@Alexqw May be worth using publishpoint with gt=dvr which should return the right m3u8 playlist.

BaumSchorle commented 10 years ago

HOF game is working on my system now, seems like they have already changed it.

BaumSchorle commented 10 years ago

Guys I provided a fix for this, we need to test this next weeks when new games are available.

dgsgc commented 10 years ago

HOF game is now working for me as well, thanks for the quick fix.

Is there no way to get the higher bitrate streams?

Thanks again.

aqw commented 10 years ago

@dgsgc HoF working now is expected. It's on a different server now than it was before. The real test is in the ~24 hour window after a game has been played. It's in a limbo state where it's still treated as live, and we need to tell it to start at the beginning of the stream rather than now (which is well after the game). @BaumSchorle provided a fix, so this should be good, but we won't know for sure until this weekend.

As for the higher bitrates, we did sacrifice the 4.5 Mb/s stream in order to get wider support. We hope we can tickle the servers into giving access to the 4.5 Mb/s streams using this new method, but it'll take some digging around to see if they're there.

jmoore626 commented 10 years ago

Hi Alex

I tried the HoF game in archive last night with 0.5.2

On the higher bitrate settings, the stream would run for 5 minutes and then would dump you back to the menu. There was no indications it was buffering, it would merely get to a point, freeze, then dump you back to the xbmc-gamepass menu.

Lower quality stream ran fine.

Seems very similar to Issue #54

Jesia commented 10 years ago

@jmoore626 I had the same issue, but since i installed the latest dependencys it works for me

BaumSchorle commented 10 years ago

@jmoore626 I can not confirm your issue. I am watching the HOF game now for about 10 minutes, everything works as expected.

If you provide some logs, we maybe can help!

RootPhish commented 10 years ago

Trying to watch last nights Bengals at Chiefs game, but I'm only getting "The game has ended". Probably because of the "Limbo" period that @Alexqw mentioned earlier? Do you need any logs from me or is this already a known issue?

(Managed to work around this for now by forcing game_version to 'dvr' in default.py)

BaumSchorle commented 10 years ago

@RootPhish thanks for pointing this out, I provided a fix for this! Please download the latest files!

aqw commented 10 years ago

@BaumSchorle I just pushed a fix on top of yours. It is untested, so feel free to shit all over it. ;-)

Your fix did fix the problem but had two problems:

Let me knwo if I'm in error.

---Alex

BaumSchorle commented 10 years ago

@Alexqw nope, there are actually condensed versions available and playable, that's why I added it. I will reedit it ;)

the finished games were not marked as Live because the game_info gets overwritten a few lines later, but you are right it's sloppy! ;)

aqw commented 10 years ago

@BaumSchorle

Ahh, good to know. Thanks for re-fixing. :-)

Then definetely, please don't rewrite game_info or game_versions. It makes it more difficult to debug (as I obviously missed that's what was happening).

If anything, just ignore "Live" from inside select_version, etc.

---Alex

BaumSchorle commented 10 years ago

@Alexqw done, we are already ignoring it in select_version, didn't figure that out ;)

RootPhish commented 10 years ago

Thanks for your quick actions, guys. At halftime, I updated to the latest version and it works like a charm! On to watch the rest of this exciting game. Who Dey!

aqw commented 10 years ago

@RootPhish Glad it's working. @BaumSchorle is the master of all. ;-)

---Alex