search

pihome-shc / pihome

PiHome - Smart Heating, Ventilation and Air Conditioning (HVAC)
http://www.pihome.eu
Other
52 stars 25 forks source link

max_operation_time for zones #366

Closed twa127 closed 3 years ago

twa127 commented 3 years ago

Hi,

I've introduced a small issue with the change to the zone table.

I've placed max_operation_time in the new zone_sensors_table but left in on the zone add/edit screen for all zones. The issue is that when adding/edititing cat2 zones the zone_sensors_table is not updated.

Not too much of a problem as for as far as I can see the value is not currently used anywhere.

There are 2 possible solutions

  1. Remove max_operation_time input from the zone add/edit screen for cat2 zones
  2. Move max_operation_time from the zone_sensors_table to the zone_table

I personally think 2 is better as maybe max_operation_time might be useful as a safety feature for all zone categories.

Any thoughts?

pihome-shc commented 3 years ago

@twa127 yes i agree 2nd option is better.

pihome-shc commented 3 years ago

@twa127 any further update required for this issue?

twa127 commented 3 years ago

No I think all resolved now