search

pihome-shc / pihome

PiHome - Smart Heating, Ventilation and Air Conditioning (HVAC)
http://www.pihome.eu
Other
55 stars 25 forks source link

Piconnect #395

Closed twa127 closed 4 years ago

twa127 commented 4 years ago

Hi,

I'm a bit confused looking at piconnect.php, its function now appears to be table maintenance, perhaps the name is now not appropriate.

pihome-shc commented 4 years ago

@twa127 yes you are right, at this time it is more of table maintenance. you are thinking to rename it?

twa127 commented 4 years ago

yes perhaps but maybe the sequence could be done in db.php ie rather than setting purge in db.php why not do the deletions

pihome-shc commented 4 years ago

yes but once PiConnect become available to general public we dont have to modify main software hence leaving this delete in piconnect.php file.

twa127 commented 4 years ago

ah, so would you prefer to leave it as it is for now?

pihome-shc commented 4 years ago

yes, better to leave it as it is.

twa127 commented 4 years ago

Okay, I'll close this issue