search

pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox
http://pik-potsdam.de/~donges/pyunicorn/
Other
195 stars 86 forks source link

fix version in setup #151

Closed arnaudon closed 2 years ago

arnaudon commented 3 years ago

In init.py, having import setup causes conflicts with other setup.py from other packages, this is a cleaner way to import the code version. I also added absolute import in init.py, to be safer (my pip complained about that as well). Otherwise, great code thanks!

ntfrgl commented 2 years ago

Thank you for providing this PR! This set of problems should be fully resolved with the commit linked above, which will be reflected in an upcoming new release including official wheels. Please let us know in case you have any trouble installing pyunicorn from the current master branch, in which case we will attempt to find a solution as quickly as possible.

Cython is now declared as a build dependency, which means that your Python package manager (e.g., pip) is responsible for automatically providing the Cython compiler without any user intervention. After the package installation process is completed, Cython is not required as a runtime dependency. The version information is now retrieved via importlib.metadata from the Python standard library.

arnaudon commented 2 years ago

You are welcome! Thanks for the fix, I'll try again soon, but your fix seems to be the right one!