Closed fkuehlein closed 1 year ago
Update: build errored :(
... but due to an issue with dependency installation, namely
$ travis_retry conda install -c conda-forge networkx matplotlib cartopy sphinx
failing or timing out on all 4 builds because environment cannot be resolved. huh ...
Probably something wrong in the .travis.yaml
? Could not resolve it yet, all install commands listed there run flawlessly on my conda.
LGTM! Thank you for this thorough cleanup!
I resolved the problem with the dependency solver by replacing it: https://www.anaconda.com/blog/conda-is-fast-now
Yay, thank you so much for your work! The CI speedup is remarkable and should be of great use in saving runtime credit with Travis.
I will take care of the remaining pylint warning concerning cartopy.
This branch resolves Issue #191 by resolving all remaining
flake8
andpylint
flags:too-many-arguments
inEventSeriesClimateNetwork.__init__()
by handling all optional keyword arguments for parent classes in the**kwargs
parameter.kwargs
is then split into dictionaries for respective parent class methods in the method body. This way, the behavior of the method remains unchanged from the outside.arguments-renamed
flags in overriding methods. These have been resolved through realignment of overriding method arguments with their parent class counterparts by way of:In total, this should hopefully make the Travis builds pass again!
In addition to that, the branch contains additional tests against Issues #145 and #128 in 6b96ced40ef21e2add6393411eb97d5d05194fea, which can hence be closed as well.
Please let me know if you find any inconsistencies or shortcomings in the above described work and will add to it.
Best, Fritz