pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox
http://pik-potsdam.de/~donges/pyunicorn/
Other
200 stars 87 forks source link

CI, TEST: make Travis builds pass again + additional tests in `test_timeseries` #192

Closed fkuehlein closed 1 year ago

fkuehlein commented 1 year ago

This branch resolves Issue #191 by resolving all remaining flake8 and pylint flags:

In total, this should hopefully make the Travis builds pass again!

In addition to that, the branch contains additional tests against Issues #145 and #128 in 6b96ced40ef21e2add6393411eb97d5d05194fea, which can hence be closed as well.

Please let me know if you find any inconsistencies or shortcomings in the above described work and will add to it.

Best, Fritz

fkuehlein commented 1 year ago

Update: build errored :(

... but due to an issue with dependency installation, namely

$ travis_retry conda install -c conda-forge networkx matplotlib cartopy sphinx

failing or timing out on all 4 builds because environment cannot be resolved. huh ...

Probably something wrong in the .travis.yaml? Could not resolve it yet, all install commands listed there run flawlessly on my conda.

ntfrgl commented 1 year ago

LGTM! Thank you for this thorough cleanup!

I resolved the problem with the dependency solver by replacing it: https://www.anaconda.com/blog/conda-is-fast-now

fkuehlein commented 1 year ago

Yay, thank you so much for your work! The CI speedup is remarkable and should be of great use in saving runtime credit with Travis.

I will take care of the remaining pylint warning concerning cartopy.