pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox
http://pik-potsdam.de/~donges/pyunicorn/
Other
195 stars 86 forks source link

Resolved line distribution issues and additional test coverage for `RecurrencePlot` #209

Closed fkuehlein closed 6 months ago

fkuehlein commented 6 months ago

See #166 for some notes on previous commits.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f374ffd) 58.42% compared to head (601af09) 60.72%.

Files Patch % Lines
src/pyunicorn/timeseries/recurrence_plot.py 88.33% 7 Missing :warning:
src/pyunicorn/timeseries/cross_recurrence_plot.py 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #209 +/- ## ========================================== + Coverage 58.42% 60.72% +2.29% ========================================== Files 44 44 Lines 6369 6357 -12 ========================================== + Hits 3721 3860 +139 + Misses 2648 2497 -151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ntfrgl commented 6 months ago

@fkuehlein, thank you for implementing and testing the required changes! Could you please carefully review my updates above before we merge? I found some minor remaining bugs, extended your tests to the "sparse" RQA use case, and refactored the Cython implementation to significantly reduce its redundancy. Hopefully, going forward, this will also make it easier to extend RQA methods and other highly parametric functions.

fkuehlein commented 6 months ago

Cool, thank you @ntfrgl! Great to lose some weigth in that Cython module especially, should be helpful for future enhancements indeed. It all looks good to me.