pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox
http://pik-potsdam.de/~donges/pyunicorn/
Other
195 stars 87 forks source link

review map plotting #217

Closed fkuehlein closed 8 months ago

fkuehlein commented 8 months ago

I renamed it to MapPlot because you can now only plot a single dimension at a time. Of course this can be extended by the user. See ClimateNetwork.ipynb tutorial for example usage.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2f40e1a) 60.82% compared to head (562581f) 62.82%.

Files Patch % Lines
src/pyunicorn/climate/map_plot.py 94.59% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #217 +/- ## ========================================== + Coverage 60.82% 62.82% +2.00% ========================================== Files 44 43 -1 Lines 6356 6220 -136 ========================================== + Hits 3866 3908 +42 + Misses 2490 2312 -178 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ntfrgl commented 8 months ago

@fkuehlein, please kindly check my minor edits above. Otherwise, this should be good to go.

fkuehlein commented 8 months ago

Thank you for those additions, looks good!