pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox
http://pik-potsdam.de/~donges/pyunicorn/
Other
195 stars 86 forks source link

Release 0.7 #218

Closed fkuehlein closed 4 months ago

fkuehlein commented 5 months ago

Finalising the release.

TODO:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.76%. Comparing base (634d3a0) to head (dbcbf4c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #218 +/- ## ======================================= Coverage 63.76% 63.76% ======================================= Files 44 44 Lines 6221 6221 ======================================= Hits 3967 3967 Misses 2254 2254 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fkuehlein commented 4 months ago
  • [ ] check sdist with build command (correct file list, successful installation from sdist)

For testing purposes I just ran build as instructed in the above link, successfully creating a source distribution (.tar.gz). It appears to contain all the correct files and I could install it and run tox.

build also creates a built distribution, but specific to my system (pyunicorn-0.7.0b1-cp310-cp310-macosx_10_9_x86_64.whl). As I understand, cross-compilation is not straightforward and providing built distributions is not required to upload on PyPI, so we would probably not use that, right @ntfrgl? Looking at previous GitHub releases I only see source distribution archives ...

ntfrgl commented 4 months ago

I agree. Given that our user community is relatively small, and that the installation of the source distribution is actively tested on all major platforms as per #214, the overhead of providing wheels with the release seems unjustified.

fkuehlein commented 4 months ago

Thank you for reviewing and polishing, @ntfrgl! I'll take care of the remaining steps now.