Closed ntfrgl closed 7 months ago
Attention: 54 lines
in your changes are missing coverage. Please review.
Comparison is base (
2739894
) 62.82% compared to head (415e2bf
) 63.76%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks a lot @ntfrgl for all the work put into implementing this and also for all the little cleanups and refactors along the way!
I took a bit of time to understand the structure and functionality of the new Cached
class in detail, although its application appears straightforward indeed. I think I'll be able to maintain it, continuously include it in further classes and eventually add subclass-specific tests.
I added the remaining minor fixes in the commits above to make sure all checks pass, so this PR should be good to go.
Thank you for the careful review. I'm glad to know the project in your hands.
As a last addition, I slightly simplified the implementation of nested Cached
objects in afc6abf, effectively removing some debugging artifacts. But that shouldn't concern the current release.
This PR fully implements:
Cached
with a decorator@Cached.method()
,Obviously, there is still more refactoring to be done to make the caching system consistent across the project, but this PR should deliver on the main concern of #148, namely a well-behaved caching decorator. The last commit message should provide enough context for reviewing. @fkuehlein, please raise any concerns you might have, since you are expected to maintain this code going forward.