search

pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox
http://pik-potsdam.de/~donges/pyunicorn/
Other
195 stars 87 forks source link

Review Linting #224

Closed fkuehlein closed 3 months ago

fkuehlein commented 4 months ago

the idea is to drop global disables of Pylint flags in pyproject.toml where possible.

This PR contains the most straightforward cases, but more work needs to be done. I would argue to keep

disable = ["duplicate-code", "invalid-name", "fixme", "missing-docstring", "no-else-return"]

for now.

Thus, "arguments-differ", "no-member" and "no-name-in-module" are yet to be re-enabled and respective cases fixed (see e.g. #222 concerning "no-member").

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 71.69811% with 15 lines in your changes missing coverage. Please review.

Project coverage is 68.63%. Comparing base (3079fda) to head (ba83d3e).

Files Patch % Lines
src/pyunicorn/core/network.py 68.57% 11 Missing :warning:
src/pyunicorn/core/geo_network.py 75.00% 1 Missing :warning:
src/pyunicorn/core/netcdf_dictionary.py 0.00% 1 Missing :warning:
...pyunicorn/funcnet/coupling_analysis_pure_python.py 80.00% 1 Missing :warning:
src/pyunicorn/timeseries/surrogates.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #224 +/- ## ========================================== + Coverage 66.94% 68.63% +1.68% ========================================== Files 44 44 Lines 6151 6138 -13 ========================================== + Hits 4118 4213 +95 + Misses 2033 1925 -108 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.