Avoid using variable name `I` in C code

pik-copan / pyunicorn

Unified Complex Network and Recurrence Analysis Toolbox

http://pik-potsdam.de/~donges/pyunicorn/

Other

200 stars 87 forks source link

Avoid using variable name `I` in C code #226

Closed fkuehlein closed 5 months ago

fkuehlein commented 5 months ago

as was the case in core/_ext/src_numerics.c.

This is because I is already used for complex numbers in the complex.h library (see #225).

Note that the remaining functions contained in that file should eventually be migrated to core/_ext/numerics.pyx.

Also, the newly released Numpy 2.0 introduces breaking changes with its C API. Migration should be considered at some point using the provided giude.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.94%. Comparing base (5e03951) to head (8943340).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #226 +/- ## ========================================== + Coverage 66.91% 66.94% +0.03% ========================================== Files 44 44 Lines 6193 6151 -42 ========================================== - Hits 4144 4118 -26 + Misses 2049 2033 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.