search

pik-piam / gdx

R package | readGDX package for R
Other
1 stars 4 forks source link

add optional parameters 'spatial' and 'temportal' parameters to readGDX #8

Closed fbenke-pik closed 7 months ago

fbenke-pik commented 7 months ago

This PR gives you more control over conversion to a magclass object when reading in gdx data. Right now, matching of spatial and temporal columns happens automatically.

tscheypidi commented 7 months ago

do the new arguments work in combination with any other argument? In particular, does it work for restore_zeros = TRUE and FALSE?

fbenke-pik commented 7 months ago

do the new arguments work in combination with any other argument? In particular, does it work for restore_zeros = TRUE and FALSE?

Yes, to the best of my knowledge, should work with both restore_zeros TRUE and FALSE (restore_zeros only affects the length of the data table that is created before applying as.magpie). Also, not setting them would pass NULL to as.magpie for spatial and temporal, which is default behavior.