pik-piam / gms

Other
1 stars 15 forks source link

fix chooseFromList error if groups is defined somewhere #60

Closed orichters closed 1 year ago

orichters commented 1 year ago

fix error introduced in https://github.com/pik-piam/gms/pull/59 if some other part of the script has defined groups (which is done by loading dplyr). @mikapfl FYI.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (72deafc) 33.41% compared to head (5296ab1) 33.45%.

:exclamation: Current head 5296ab1 differs from pull request most recent head 505c620. Consider uploading reports for the commit 505c620 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #60 +/- ## ========================================== + Coverage 33.41% 33.45% +0.04% ========================================== Files 51 51 Lines 1661 1662 +1 ========================================== + Hits 555 556 +1 Misses 1106 1106 ``` | [Impacted Files](https://codecov.io/gh/pik-piam/gms/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pik-piam) | Coverage Δ | | |---|---|---| | [R/chooseFromList.R](https://codecov.io/gh/pik-piam/gms/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pik-piam#diff-Ui9jaG9vc2VGcm9tTGlzdC5S) | `75.00% <100.00%> (+0.37%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pik-piam). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pik-piam)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.