pik-piam / gms

Other
1 stars 15 forks source link

skip cleanup of not_used.txt in CI context #90

Closed fbenke-pik closed 8 months ago

fbenke-pik commented 8 months ago

This PR skips any adjustments of not_used.txt when running when codeCheck is executed as part of the Github Actions.

See also: https://github.com/pik-piam/gms/issues/85

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.65%. Comparing base (6c17ae3) to head (0800f3f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #90 +/- ## ======================================= Coverage 41.65% 41.65% ======================================= Files 51 51 Lines 1707 1707 ======================================= Hits 711 711 Misses 996 996 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

orichters commented 8 months ago

Can we use the same setting for running make test in REMIND as well?

orichters commented 8 months ago

@fbenke-pik: I think a better way would be to do all sorts of removals only in interactive = TRUE mode. That excludes codeCheck in github actions anyway, but we can also switch that simply off in the tests and we are some steps further.

fbenke-pik commented 8 months ago

Will probably be closed in favour of https://github.com/pik-piam/gms/pull/91

orichters commented 8 months ago

I would still merge this one as well. I think github actions should not tinker with the sources in order to satisfy codeCheck. Like this, you also have a good test whether people actually commit and push the changes make check-fix has applied.

tscheypidi commented 8 months ago

Why not link this to the interactive argument as this one is specifically targeted at fixing issues? interactive = TRUE try to live fix some issues, interactive = FALSE no issue fixing?

fbenke-pik commented 8 months ago

Right, Oliver probably will do exactly that in the near future.

orichters commented 8 months ago

Closed in favor of https://github.com/pik-piam/gms/pull/92