Closed fbenke-pik closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 41.65%. Comparing base (
6c17ae3
) to head (0800f3f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can we use the same setting for running make test
in REMIND as well?
@fbenke-pik: I think a better way would be to do all sorts of removals only in interactive = TRUE
mode. That excludes codeCheck in github actions anyway, but we can also switch that simply off in the tests and we are some steps further.
Will probably be closed in favour of https://github.com/pik-piam/gms/pull/91
I would still merge this one as well. I think github actions should not tinker with the sources in order to satisfy codeCheck. Like this, you also have a good test whether people actually commit and push the changes make check-fix
has applied.
Why not link this to the interactive
argument as this one is specifically targeted at fixing issues? interactive = TRUE
try to live fix some issues, interactive = FALSE
no issue fixing?
Right, Oliver probably will do exactly that in the near future.
Closed in favor of https://github.com/pik-piam/gms/pull/92
This PR skips any adjustments of
not_used.txt
when running when codeCheck is executed as part of the Github Actions.See also: https://github.com/pik-piam/gms/issues/85