search

pik-piam / gms

Other
1 stars 15 forks source link

remove $$-expressions from declarations #94

Closed 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q closed 6 months ago

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 6 months ago

Consider this GAMS code

Parameter
  f_foo(x)   "description"
  /
    $$ondelim
    $$include "./some/file/to/read.csv";
    $$offdelim
  /
;

for which codeCheck() reports

 codeCheck reported code inconsistencies. Please fix the given warnings!
Warning messages:
1: "$$ondelim" does not follow the given naming conventions (description = "")! 
2: "$$include" does not follow the given naming conventions (description = "./some/file/to/read.csv")!

Better to filter $$-expressions, too.

LaviniaBaumstark commented 6 months ago

Fine from the technical side.

I'm not sure whether we should allow for $$ statements in our models. Maybe @LaviniaBaumstark can weigh in if she thinks we shouldn't.

fine for me, what do you think @tscheypidi ?

tscheypidi commented 6 months ago

I think as well that this can be filtered.