pik-piam / madrat

R package | May All Data be Reproducible and Transparent (MADRaT)
https://cran.r-project.org/web/packages/madrat/index.html
Other
14 stars 36 forks source link

Many filenames (links) in downloadFAO_online.R are outdated. #132

Closed moulai closed 2 years ago

moulai commented 2 years ago

Many filenames (links) in downloadFAO_online.R are outdated.

For example, the file name of Crop is Production_Crops_E_All_Data_(Normalized).zip, however, this file cannot be found in the latest datasets_E.xml (downloaded from: http://fenixservices.fao.org/faostat/static/bulkdownloads/datasets_E.xml).

And the link http://fenixservices.fao.org/faostat/static/bulkdownloads/Production_Crops_E_All_Data_(Normalized).zip has also expired.

By looking at the FAO website (https://www.fao.org/faostat/en/#data/QCL), it can be found that there is no Crops under the Production category, but Crops and livestock products, which should be downloaded from https://fenixservices.fao.org/faostat/static/bulkdownloads/Production_Crops_Livestock_E_All_Data_(Normalized).zip.

Hope that downloadFAO_online.R can be updated, after all, the FAO_online source is used a lot.

In addition, must some functions require the use of Production_Crops_E_All_Data_(Normalized).zip? Now that the file is not open to be downloaded from FAO, does it mean that some functions may not be available?

Thank you for your kind help and reply!

moulai commented 2 years ago

Sorry, I found that I opened the issue in the wrong repository. I wanted to open this issue in mrcommons.