export unitsplit - Githubissues

pik-piam / magclass

R package | Data Class and Tools for Handling Spatial-Temporal Data

GNU Lesser General Public License v3.0

4 stars 24 forks source link

export unitsplit #134

Closed orichters closed 2 years ago

orichters commented 2 years ago

put it into unitsplit.R, slightly adapted such that it also accepts strings or vectors of strings: if ncol of x is NULL, it simply puts it into a data.frame. unitsplit() can now be called not with column number, but name.
also separate the tests
add Mika and myself as authors

mikapfl commented 2 years ago

Also, I'm not sure about the pre-commit.ci failures, you didn't change anything in the dependencies, so I guess it at least doesn't get worse with this PR.

mikapfl commented 2 years ago

@johanneskoch94 you added https://github.com/pik-piam/magclass/blob/4df6a63c36df685bc1a95db6017875e5d151927c/R/as_tibble.R#L11 , but didn't add a dependency on pkgconfig in the DESCRIPTION. Do you know how to best resolve this (not related to this PR, just the place where it crops up due to better linting).

orichters commented 2 years ago

@johanneskoch94 you added

https://github.com/pik-piam/magclass/blob/4df6a63c36df685bc1a95db6017875e5d151927c/R/as_tibble.R#L11 , but didn't add a dependency on pkgconfig in the DESCRIPTION. Do you know how to best resolve this (not related to this PR, just the place where it crops up due to better linting).

added them to suggested and pre-commit is fine now. Also added further tests and the functionality to call the col by name, not only number.

johanneskoch94 commented 2 years ago

Interesting... I guess since devtools::check didn't complain, and you can only use this method when tibble, and therefore pkgconfig is installed (unless one uses ::: to call a method, which makes no sense at all), there never was a problem before. But thanks @orichters, that's what I would have suggested as well.