search

pik-piam / mip

Model intercomparison visualization package
Other
1 stars 24 forks source link

Remove Convergence Plot #81

Closed fbenke-pik closed 1 year ago

fbenke-pik commented 1 year ago

Removes the REMIND convergence plot, as mip was originally meant as an application independent visualization package.

fbenke-pik commented 1 year ago

You can argue either way. If you stress the visualization aspect, it goes into mip. If you stress the aspect of coding of GAMS logic and variables in R, it goes into remind2.

LaviniaBaumstark commented 1 year ago

Let's keep it here for now

tscheypidi commented 1 year ago

mip was originally meant as an application independent visualization package. From that perspective these specific functions violate this definition. But I also have to say that its been a while that I had a look at the package. So there might be already violations in there?

orichters commented 1 year ago

I'm sorry, but I don't really know what is going on here and don't have time to dig into it at the moment, so I let you find a good solution…

fbenke-pik commented 1 year ago

Deleting mipConvergence and moving it to remind2.