pik-piam / mrremind

The mrremind packages contains data preprocessing for the REMIND model.
GNU Lesser General Public License v3.0
4 stars 45 forks source link

EDGE_SSP1/EDGE_SSP2 return Inf FE|Industry|Solids for NEU #367

Closed 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q closed 1 year ago

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 year ago

which apparently spreads to FE|Industry and FE, as well as World.

$ tar -xOf /p/projects/rd3mod/inputdata/output/rev6.333_62eff8f7_validationremind.tgz ./historical.mif | \
    sed -n '1p; /Inf/ p' | \
    column -ts ';' | \
    less -S

Not sure whether EDGE_SSP1 and EDGE_SSP2 are relevant for anything, though.

fbenke-pik commented 1 year ago

Seems to be a Problem in calcFEdemand for Iceland

data <- calcOutput("FEdemand", subtype = "FE", aggregate = FALSE)
data["ISL",2025,"fesoi", pmatch=T]

More precisely, introduced here. Can you take a closer look @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q ?

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 year ago

So EDGE_SSP1 and EDGE_SSP2 are actually the outdated industry/fixed_shares calibration data we know to be false? Why not just delete them?

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 year ago

Also, the problem is that readEDGE('FE_stationary') returns 0 feindsolid for ISL in 2020 here:

> stationary <- readSource("EDGE", subtype = "FE_stationary")
Run readSource(type = "EDGE", subtype = "FE_stationary")
~  - loading cache convertEDGE-F0bc1a876-816e8565.rds
Exit readSource(type = "EDGE", subtype = "FE_stationary") in 46.3 seconds
> stationary['ISL',c(2015, 2020, 2025),'SSP1.feindsolid']
An object of class "magpie"
, , scenario.item = SSP1.feindsolid

      year
region      y2015 y2020        y2025
   ISL 0.00460468     0 0.0005815233
fbenke-pik commented 1 year ago

I don't mind removing this, if you know for sure the data is known to be false.

reposearch EDGE_projections suggests that calcOutput("FE", source = "EDGE_projections", scenario_proj = "SSP1|SSP2") is only used to add the data to historical.mif, so this should not affect inputdata generation in any way.

So if there are no objections by @LaviniaBaumstark, i will remove this (Anastasis and Aman have added this a long time ago, but we cannot ask them for obvious reasons).

LaviniaBaumstark commented 1 year ago

o.k., remove it if it is only needed for validation and no one cares