search

pik-piam / mrremind

The mrremind packages contains data preprocessing for the REMIND model.
GNU Lesser General Public License v3.0
4 stars 43 forks source link

Refactor according to mrdrivers update #500

Closed johanneskoch94 closed 4 months ago

johanneskoch94 commented 4 months ago

Move readPWT and readOECD over from mrdrivers, where they aren't used any longer. Adjust calls to readIMF. Drop old GDP sources from calcHistorical.

johanneskoch94 commented 4 months ago

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q, @LaviniaBaumstark The issue raised by Michaja could stem from here, although these changes should, in theory, not lead to any differences, apart from the fact that we're using new IMF data, and new scenarios of course. (Just so say, that perhaps the issue is with the new scenarios directly...)

johanneskoch94 commented 4 months ago

Also, when I ran the input data, my version of mrremind didn't include your latest commits Michaja, in case that plays a role.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 months ago

How does this branch relate to commit ace22a8 used for rev6.75jokoch_2005PPP?

johanneskoch94 commented 4 months ago

Is ace22a8 the commit of mrremind used in the input-data creation? If so, it got rewritten when I rebased this branch in preparation of the merge to develop... Different hash, same code. (I realize now that this breaks the link between the current input data version that we're testing and the r-package, but the commits were a mess, and I was relying on the fact that we will rerun the input data once all packages are merged...)