search

pik-piam / mrremind

The mrremind packages contains data preprocessing for the REMIND model.
GNU Lesser General Public License v3.0
4 stars 40 forks source link

delete no longer needed functions #502

Closed fbenke-pik closed 1 month ago

fbenke-pik commented 1 month ago

This PR suggests deletion of functions that are most likely no longer used. I checked using madrat::getDependencies and did reposearch on the cluster.

LaviniaBaumstark commented 1 month ago

regarding data for (un)emloyment maybe @pweigmann knows if this is still needed. In generall, I think we can delete all functions which are not used any more (means: not found by madrat::getDependencies)

fbenke-pik commented 1 month ago

There are some exceptions, sometimes madrat functions are used outside the madrat context and therefore cannot be tracked by getDependencies, so getDependencies is not sufficient. The ones I marked for deletion here could not be found by reposearch either.

pweigmann commented 1 month ago

regarding data for (un)emloyment maybe @pweigmann knows if this is still needed. In generall, I think we can delete all functions which are not used any more (means: not found by madrat::getDependencies)

Which file were you referring to specifically? The employment scripts from Aman use calcOutput("Employmentfactors", .., readSource("BP",... and a lot of .rds files. So I think we should be fine if we ever wanted to use his formulations again.