search

pik-piam / mrremind

The mrremind packages contains data preprocessing for the REMIND model.
GNU Lesser General Public License v3.0
4 stars 40 forks source link

Drop dependency on assertthat and refactor calcTheil #509

Closed johanneskoch94 closed 4 weeks ago

johanneskoch94 commented 1 month ago

Hey, I tagged you Björn because you're listed as author... but perhaps I should tag someone else? In any case, I just refactored the function, while I was dropping the assertthat dependency :)

johanneskoch94 commented 4 weeks ago

Yeah, assertthat is a bit nicer that stopifnot, but since it really is the only appearance in the package (and in all our packages for that matter) I thought it was cleaner to use stopifnot... Thanks for the review!