pik-piam / piamInterfaces

0 stars 18 forks source link

Adjustments in line with PR361 (Fix EDGE-T mapping issues) #374

Closed laurinks closed 1 month ago

laurinks commented 1 month ago

Purpose of this PR

Make adjustments in mapping_ScenarioMIP.csv to mirror changes made in PR #361 affecting mapping_AR6.csv and mapping_NAVIGATE.csv.

A few comments:

Checklist:

It is recommended to have a look at the tutorial before submission.

laurinks commented 1 month ago

@johannah-pik : I will take care of the failing checks (this has to do with me currently being unable to run make build). But it will not affect the mapping file.

laurinks commented 1 month ago

@orichters : I could finally make "make build" work on my local computer. At some point I was choosing "minor revision" which made the version number update. Is this okay/correct or should I have made a different choice? Overall, please let me know if something is wrong. It is the first time, so particularly happy to learn how to do the process right :)

johannah-pik commented 1 month ago

@laurinks looks good! I noticed two things when I checked the mapping:

and do you meant that the Two Wheelers are not included?

johannah-pik commented 1 month ago

Could you replace FE|Transport with bunkers by FE|++|Transport in the NAVIGATE mapping as well? Then I don't need to make a separate PR. Thanks :)

laurinks commented 1 month ago

Thank you for the corrections, @johannah-pik ! I made the changes for ScenarioMIP and NAVIGATE with the latest commit. Indeed, there was a "not" missing.