search

pik-piam / remind

Contains the REMIND-specific routines for data and model output manipulation.
3 stars 18 forks source link

Policy cost reporting sanity check #100

Closed johanneskoch94 closed 3 years ago

johanneskoch94 commented 3 years ago

Hi, I put this in after discussions with Lavinia and Björn, so that automatic policy cost reporting only happens when the the gdp_scenarios are the same between policy and reference runs. This was done so that policy cost weren't reported for nonsensical policy-reference pairs. The output.R script policyCosts.R was supposed to be used to create specific policy costs reportings.
Should this be changed? What should to be done instead? @fbenke-pik @LaviniaBaumstark @bs538 @strefler

https://github.com/pik-piam/remind/blob/fed4b488a714e2603e39bcc8feb3dd78925fd14a/R/convGDX2MIF.R#L57-L74

LaviniaBaumstark commented 3 years ago

I still think that it is good to calculate the policy cost only if the GDP-scenarios were the same. Otherwise it might be interpret in a wrong way and we really should avoid this. In addition, the policy cost can be calculated in reference to many different scenarios (e.g. base, NPi, delay, etc.) which all can be correct and depends on the research question of the analysis. So, I vote for keeping it as it is.

strefler commented 3 years ago

The problem is, that cm_GDPscen is not written to the gdx. So policy costs are actually never reported and always have to be added afterwards.

LaviniaBaumstark commented 3 years ago

in core/sets.gms the following lines should ensure that this information is in the gdx: SETS

LaviniaBaumstark commented 3 years ago

in my runs for the technical REMIND paper the information on cm_GDPscen is in the gdx - just checked

LaviniaBaumstark commented 3 years ago

but no policy costs are reported, there seems to be a bug in the sensible check, @johanneskoch94, please, could you fix this

johanneskoch94 commented 3 years ago

Yes! Thanks for your input.

johanneskoch94 commented 3 years ago

OK. So there is no bug in the sensibility check. The reason @strefler that the policy costs aren't computed automatically for you, is that you're using an old remind version (see Lavinia's comment above), where https://github.com/remindmodel/remind/blob/d6b54940165364c3a884bf6933d3d137bd572198/core/sets.gms#L15-L17 doesn't include the line cm_GDPscen "cm_GDPscen as set for use in GDX" /%cm_GDPscen%/ yet.