search

pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.
0 stars 40 forks source link

Update reporting after renaming v33_emi to vm_emiCdrTeDetail #503

Closed tabeado closed 8 months ago

tabeado commented 8 months ago

Update reporting after renaming v33_emi to vm_emiCdrTeDetail in https://github.com/remindmodel/remind/pull/1517

amerfort commented 8 months ago

The reporting is supposed to have a certain backwards-compatibility, right? So we would probably have to have a check if v33_emi still exists (because the respective gdx is a little older) and do the calculation the old way in this case. @katarkow would you agree?

tabeado commented 8 months ago

@amerfort My idea was: In line 176 R is looking for either v33_emi or vm_emiCdrTeDetail (I copied this from other parts of the code). If we have the newest gdx version after the renaming, it only has vm_emiCdrTeDetail, if it is before that it finds v33_emi. If it is before the refactoring, Kasia's following code covers it. All these cases now feed into the R element "vm_emiCdrTeDetail", so we don't have to take care of it in other parts of the code. Does this miss anything?

amerfort commented 8 months ago

Oh I totally missed that in the PR, I'm so sorry! Thanks for taking care of this and thanks for explaining!