pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.
0 stars 40 forks source link

missing FE Industry variables in reporting #517

Closed orichters closed 7 months ago

orichters commented 7 months ago

Dear colleagues,

remind2 buildLibrary complains that:

2. Test if REMIND reporting produces mandatory variables for NAVIGATE reporting ('test-piamInterfaces-NAVIGATE.R:26:5') - The following variables are expected in the piamInterfaces package,
          but cannot be found in the reporting generated:
 FE|Non-energy Use|Industry (EJ/yr),
 FE|w/o Non-energy Use|Industry (EJ/yr),
 FE|w/o Non-energy Use|Industry|Gases (EJ/yr),
 FE|w/o Non-energy Use|Industry|Liquids (EJ/yr),
 FE|w/o Non-energy Use|Industry|Solids (EJ/yr),

As for example FE|w/o Non-energy Use|Industry|Solids was in the template already at least since Feb 2023, I suspect this is caused by a change in Industry FE reporting? Maybe @JakobBD or @mellamoSimon, do you have an idea?

mellamoSimon commented 7 months ago

Hi Oli, Thank you for bringing this up. Does vm_demFENonEnergySector exist in the remind version that you used? it might be a problem of backward compatibility. I'll look into it :)

orichters commented 7 months ago

For the test, a gdx file is downloaded: https://github.com/pik-piam/remind2/blob/master/tests/testthat/test-piamInterfaces-NAVIGATE.R#L8

This file is probably outdated, indeed.

@fbenke-pik might remember who gave him this file.

mellamoSimon commented 7 months ago

ok, I will wait for that feedback. For the records, when vm_demFENonEnergySector (i.e., the flow of energy carriers used as feedstock in the chemical sector) does not exist, those variables (FE|Non-energy Use|Industry (EJ/yr), etc.) are only calculated with an ad-hoc ex-post fix (by @fschreyer ) that was designed for the Ariadne project and is hidden behind a switch.

orichters commented 7 months ago

But somehow before your change these variables were calculated for the gdx file in question, but now they aren't anymore. Is that something you can fix easily (maybe the switch can be adjusted)?

fbenke-pik commented 7 months ago

But somehow before your change these variables were calculated for the gdx file in question, but now they aren't anymore. Is that something you can fix easily (maybe the switch can be adjusted)?

Are you sure this was working before? I remember sth related to industry non-energy use that was never working, but we did not exclude it because it was supposed to be calculated eventually, once Simóns enhancements were merged.

I think I got the Navigate REMIND run in the gdx from Nico. As NAVIGATE is basically over and there are no new REMIND runs for this project (that is what I am assuming at least), just excluding these variables for this particular template might be the best solution.

Whatever you decide. If you want me to use a new gdx for this check, just send it to me and i will replace it.

mellamoSimon commented 7 months ago

But somehow before your change these variables were calculated for the gdx file in question, but now they aren't anymore. Is that something you can fix easily (maybe the switch can be adjusted)?

sure, but the reported values will be very sketchy. I would argue that it's better not to report those variables if we don't really calculate them.

orichters commented 7 months ago

Ok, then I add to the NAVIGATE template that it should no expect these variables.