fix and simplify NGFS+SHAPE piamInterfaces test

pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.

0 stars 40 forks source link

fix and simplify NGFS+SHAPE piamInterfaces test #534

Closed orichters closed 6 months ago

orichters commented 6 months ago

Noticed that this code did not actually work, because unique("a", "b") is just "a", so a c() was missing there. So actually NGFS and SHAPE were never tested, but only the AR6 part.
Instead of running own tests on NGFS and SHAPE gdx files, integrate the piamInterfaces check into the usual convGDX2MIF test
Add a check for the latest NPi AMT run
cleanup as part of https://github.com/pik-piam/remind2/issues/524

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 6 months ago

Noticed that this code did not actually work, because unique("a", "b") is just "a", so a c() was missing there. So actually NGFS and SHAPE were never tested, but only the AR6 part.

I have seen this bug somewhere else only last week. I wonder how common it is …