search

pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.
0 stars 40 forks source link

Non-energy use missing from ariadne reporting #535

Closed orichters closed 6 months ago

orichters commented 6 months ago

Current output of make test for remind2:

Warning (test-piamInterfaces-Ariadne.R:24:5): Test if REMIND reporting produces mandatory variables for Ariadne reporting
The following variables are expected in the piamInterfaces package,
          but cannot be found in the reporting generated:
 Emi|CO2|w/o Non-energy Use|LULUCF national accounting (Mt CO2/yr),
 Emi|CO2|w/ Bunkers|w/o Non-energy Use (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|ETS (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Energy and Industrial Processes (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Energy (Mt CO2/yr),
 Emi|CO2|w/ Bunkers|w/o Non-energy Use|Energy (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Energy|Demand (Mt CO2/yr),
 Emi|CO2|w/ Bunkers|w/o Non-energy Use|Energy|Demand (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Energy|Demand|Industry (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Energy|Demand|Industry|Chemicals (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Gross|Energy (Mt CO2/yr),
 Emi|CO2|w/o Non-energy Use|Gross|Energy|Demand|Industry (Mt CO2/yr),
 Emi|GHG|w/o Non-energy Use|LULUCF national accounting (Mt CO2eq/yr),
 Emi|GHG|w/o Non-energy Use|Energy (Mt CO2eq/yr),
 Emi|GHG|w/o Non-energy Use|Industry (Mt CO2eq/yr),
 Emi|GHG|w/o Non-energy Use|ETS (Mt CO2eq/yr),
 Emi|GHG|w/o Non-energy Use|ETS|Industry (Mt CO2eq/yr)
mellamoSimon commented 6 months ago

waiting for approval on this one :) https://github.com/pik-piam/remind2/pull/530

mellamoSimon commented 6 months ago

on second thought, let me have a look to see if that PR also fixes that...

mellamoSimon commented 6 months ago

on second thought, let me have a look to see if that PR also fixes that...

yup testthat::test_file("tests/testthat/test-piamInterfaces-Ariadne.R") passes with [ FAIL 0 | WARN 0 | SKIP 0 | PASS 1 ]

fschreyer commented 6 months ago

waiting for approval on this one :) #530

Are you waiting for review? Could you rerequest review on github on this one if I you are done and I should take a look?

mellamoSimon commented 6 months ago

sure, like re-request a review? thanks!