search

pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.
0 stars 40 forks source link

add test for ranges on convGDX2MIF() output #538

Closed 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q closed 3 months ago

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 6 months ago

close #526

orichters commented 6 months ago

Wouldn't it make sense to run this check every time convGDX2MIF is run, not only in the tests? If there is such an inconsistency in any run, it would be good to know…

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 6 months ago

That dawned on me over the weekend as well.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 6 months ago

I will hold this back anyhow, since the test would currently break remind2 building (because remind2 is broken).

orichters commented 6 months ago

Or, you could: turn stop into warning, accept that warning in .buildLibrary, and merge it, so people working on the issues can more easily keep track of these inconsistencies (and make sure we don't add some).

Of course, this implies that people would actually care about these test warnings. History shows they don't.