pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.
0 stars 40 forks source link

fix variable naming to make it compatible with remind again #556

Closed mellamoSimon closed 6 months ago

mellamoSimon commented 6 months ago

the PR (https://github.com/remindmodel/remind/pull/1584) fixing the naming of new variables in remind's industry module broke the reporting and this fixes it.

(running buildLibrary() rn)

mellamoSimon commented 6 months ago

ups, made a mistake 😓 will fix it right away

mellamoSimon commented 6 months ago

for the records, this is what I get for the summation checks:

### Analyzing provided data.
# Use extractVariableGroups to check if summation groups add up.
# Analyzing results of model REMIND

variable groups found in extractVariableGroups                                

Carbon Management|Carbon Capture >                                            
   + Carbon Management|Carbon Capture|+|Biomass|Pe2Se                      
   + Carbon Management|Carbon Capture|+|Fossil|Pe2Se                       
   + Carbon Management|Carbon Capture|+|Industry Energy                    
   + Carbon Management|Carbon Capture|+|Industry Process                   
   + Carbon Management|Carbon Capture|+|DAC                                
Relative difference between 0.0000000187% and 28.8%, absolute difference up to 0.377 Mt CO2/yr.

Carbon Management|Storage >                                                   
   + Carbon Management|Storage|+|Biomass|Pe2Se                             
   + Carbon Management|Storage|+|Fossil|Pe2Se                              
   + Carbon Management|Storage|+|Industry Energy                           
   + Carbon Management|Storage|+|Industry Process                          
   + Carbon Management|Storage|+|DAC                                       
Relative difference between 0.0000000989% and 28.8%, absolute difference up to 0.102 Mt CO2/yr.

Emi|CO2|+|Energy >                                                            
   + Emi|CO2|Energy|+|Supply                                               
   + Emi|CO2|Energy|+|Demand                                               
   + Emi|CO2|Energy|+|Waste                                                
Relative difference between 0.0000000129% and 0.00403%, absolute difference up to 0.365 Mt CO2/yr.

Emi|CO2|Gross|Energy >                                                        
   + Emi|CO2|Gross|Energy|+|Supply                                         
   + Emi|CO2|Gross|Energy|+|Demand                                         
   + Emi|CO2|Gross|Energy|+|Waste                                          
Relative difference between 0.0000000116% and 0.00402%, absolute difference up to 0.365 Mt CO2/yr.

Emi|GHG|++|ESR <>                                                             
   + Emi|GHG|ESR|+|Industry                                                
   + Emi|GHG|ESR|+|Transport                                               
   + Emi|GHG|ESR|+|Buildings                                               
   + Emi|GHG|ESR|+|Agriculture                                             
   + Emi|GHG|ESR|+|Energy Waste                                            
   + Emi|GHG|ESR|+|Waste                                                   
Relative difference between -1.4% and 0.019%, absolute difference up to 31.8 Mt CO2eq/yr.

Emi|GHG|++|ETS >                                                              
   + Emi|GHG|ETS|+|Energy Supply                                           
   + Emi|GHG|ETS|+|Industry                                                
   + Emi|GHG|ETS|+|Transport                                               
   + Emi|GHG|ETS|+|non-BECCS CDR                                           
   + Emi|GHG|ETS|+|Extraction                                              
   + Emi|GHG|ETS|+|Energy Waste                                            
   + Emi|GHG|ETS|+|Waste                                                   
Relative difference between 0.0000000224% and 0.00708%, absolute difference up to 0.365 Mt CO2eq/yr.

Emi|GHG|++|Outside ETS and ESR <>                                             
   + Emi|GHG|Outside ETS and ESR|+|Transport                               
   + Emi|GHG|Outside ETS and ESR|+|Land-Use Change                         
   + Emi|GHG|Outside ETS and ESR|+|F-Gases                                 
Relative difference between -15519% and 14.8%, absolute difference up to 31.8 Mt CO2eq/yr.

Emi|GHG|+++|Energy >                                                          
   + Emi|GHG|Energy|+|Supply                                               
   + Emi|GHG|Energy|+|Demand                                               
   + Emi|GHG|Energy|+|Waste                                                
Relative difference between 0.0000000125% and 0.00351%, absolute difference up to 0.365 Mt CO2eq/yr.

Emi|GHG|Gross|Energy >                                                        
   + Emi|GHG|Gross|Energy|+|Supply                                         
   + Emi|GHG|Gross|Energy|+|Demand                                         
   + Emi|GHG|Gross|Energy|+|Waste                                          
Relative difference between 0.0000000113% and 0.00351%, absolute difference up to 0.365 Mt CO2eq/yr.

# Summary of summation group checks for model REMIND:
# 9 equations are not satisfied but should according to extractVariableGroups.
# All deviations can be found in the returned object.
# To get more detailed information on 'Carbon Management|Carbon Capture', run piamInterfaces::variableInfo('Emi|GHG|Gross|Energy').

# As generatePlots=FALSE, no plot comparison was produced.

# The filtered data contains 84 variables.

### Analyzing provided data.
# Use C:/Users/simonlei/Nextcloud/Documents/Models/local-remind2/remind2/inst/extdata/additional_summation_checks.csv to check if summation groups add up.
# Analyzing results of model REMIND

variable groups found in additional_summation_checks.csv                      

Emi|CO2 >                                                                     
   + Emi|CO2|Gross|Energy|Supply|+|Electricity                             
   + Emi|CO2|Gross|Energy|Supply|Non-electric                              
   + Emi|CO2|Energy|Demand|+|Transport                                     
   + Emi|CO2|Gross|Energy|Demand|+|Industry                                
   + Emi|CO2|Energy|Demand|+|Buildings                                     
   + Emi|CO2|Energy|Demand|+|CDR                                           
   + Emi|CO2|+|Land-Use Change                                             
   + Emi|CO2|+|Industrial Processes                                        
   + Emi|CO2|CDR|BECCS                                                     
   + Emi|CO2|CDR|Industry CCS|Synthetic Fuels                              
   + Emi|CO2|CDR|DACCS                                                     
   + Emi|CO2|CDR|EW                                                        
   + Emi|CO2|Gross|Energy|+|Waste                                          
   + Emi|CO2|CDR|Materials|+|Plastics                                      
Relative difference between 0.0000000125% and 0.00294%, absolute difference up to 0.365 Mt CO2/yr.

Emi|CO2|Cumulated >                                                           
   + Emi|CO2|Cumulated|Land-Use Change                                     
   + Emi|CO2|Cumulated|Industrial Processes                                
   + Emi|CO2|Cumulated|Energy|Demand|Transport                             
   + Emi|CO2|Cumulated|Gross|Energy|Demand|Industry                        
   + Emi|CO2|Cumulated|Energy|Demand|Buildings                             
   + Emi|CO2|Cumulated|Energy|Demand|CDR                                   
   + Emi|CO2|Cumulated|Gross|Energy|Supply|Non-electric                    
   + Emi|CO2|Cumulated|Gross|Energy|Supply|Electricity                     
   + Emi|CO2|Cumulated|Gross|Energy|Waste                                  
   + Emi|CO2|Cumulated|CDR|BECCS                                           
   + Emi|CO2|Cumulated|CDR|Industry CCS|Synthetic Fuels                    
   + Emi|CO2|Cumulated|CDR|DACCS                                           
   + Emi|CO2|Cumulated|CDR|EW                                              
   + Emi|CO2|Cumulated|CDR|Materials|Plastics                              
Relative difference between 0.000000012% and 0.00122%, absolute difference up to 5.26 Mt CO2.

Emi|GHG >                                                                     
   + Emi|GHG|Gross|Energy|Supply|Electricity                               
   + Emi|GHG|Gross|Energy|Supply|Non-electric                              
   + Emi|GHG|Energy|Demand|+|Buildings                                     
   + Emi|GHG|Gross|Energy|Demand|+|Industry                                
   + Emi|GHG|Energy|Demand|+|Transport                                     
   + Emi|GHG|Energy|Demand|+|CDR                                           
   + Emi|GHG|Gross|Energy|+|Waste                                          
   + Emi|GHG|+++|Industrial Processes                                      
   + Emi|GHG|+++|Waste                                                     
   + Emi|GHG|+++|Agriculture                                               
   + Emi|GHG|+++|Land-Use Change                                           
   + Emi|CO2|CDR|BECCS                                                     
   + Emi|CO2|CDR|DACCS                                                     
   + Emi|CO2|CDR|Industry CCS|Synthetic Fuels                              
   + Emi|CO2|CDR|EW                                                        
   + Emi|CO2|CDR|Materials|+|Plastics                                      
Relative difference between 0.0000000109% and 0.00175%, absolute difference up to 0.365 Mt CO2eq/yr.