pik-piam / remind2

The remind2 package contains the REMIND-specific routines for data and model output manipulation.
0 stars 40 forks source link

Clean up reportEmi() and reportFE() functions by removing backward compatibilities #652

Closed fschreyer closed 1 week ago

fschreyer commented 1 week ago

This PR cleans up two reporting functions by removing if-clauses required for GDX files before REMIND 3.3.0 addressing issue #524.

To see the specific backward compatibilities I removed, please see the commit list.

this list remove backwards compatability in reportFE for GDX files … - adb5ca6 without `fegat` dimension in `vm_demFeSector` (used for deleted transport complex realization) - 1e26678 with CDR module realization other than `portfolio` - 8faf3b2 without `o37_demFeIndSub` - acb686b without `vm_denFeNonEnergySector` - d9e1569 without `pm_IndstCO2Captured` - 4b84f09 without `o37_demFeIndSub` - 580c744 without `vm_incinerationEmi` - 33a9326 without `v37_plasticsCarbon` and `vm_demFENonEnergySector`, i.e. from before feedstocks implementation - 161f911 without `vm_emienFuelEx` - 68accdd without `vm_emiCdrTeDetail`, i.e. from before CDR portfolio realization - d6231db remove deprecated Ariadne industrial process emissions reporting from reportEmi() - da59e10 remove bunker correction for deprecated emissisons variables corrected for non-energy use - 7a9e824 add bunker correction to two emissions variables again that had accidentally been removed

This is pure code cleaning and I checked for /p/projects/remind/modeltests/remind/output/SSP2-EU21-PkBudg1050-AMT_2024-08-31_03.27.11 that values in the mif-files do not change.

Let me know if you have any concerns about the parts I removed.