search

pik00 / auto-sub

Automatically exported from code.google.com/p/auto-sub
0 stars 0 forks source link

Extra period in end of filename with english #173

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Set english name to ""
2. Set to download english
2. Set dutch to "du"
3. Watch name of a downloaded srt

What is the expected output? What do you see instead?
I would have hoped that the resulting download of english subtitle was 
"Series.Name.SxxExx.srt" What happens is that there's an additional period 
(".") at the end; "Series.Name.SxxExx..srt" which means it doesn't match the 
.mkv and must be renamed manually for most software to pick it up automatically

What version of the product are you using? On what operating system?
0.5.6 on Ubuntu

Please provide any additional information below.

Original issue reported on code.google.com by petter.s...@gmail.com on 4 Feb 2013 at 7:31

GoogleCodeExporter commented 8 years ago 
I fixed this on my end by removing the . in "." line 53 of checkSub.py:

            engsrtfile = os.path.splitext(originalfile)[0] + u"" + autosub.SUBENG + u".srt"

Original comment by petter.s...@gmail.com on 4 Feb 2013 at 7:34

GoogleCodeExporter commented 8 years ago 
Like i already said in other issue's for example:
http://code.google.com/p/auto-sub/issues/detail?id=85

AutoSub is written primarily for downloading Dutch subtitles, English subtitle 
are just added as a 'bonus' feature, but is not the main goal of AutoSub. Feel 
free to change to project to your needs (that is why it is opensource after all 
:) ), but we will not implement and support your feature request.

Original comment by romke.va...@gmail.com on 7 Feb 2013 at 11:58

GoogleCodeExporter commented 8 years ago 
I'm sorry, but the argument for "WontFix" is rather weak. This is a bug which 
you fixed (trivially) for the Dutch version. The attached patch does this for 
the English version too. Please incorporate it in the main code branch.

Original comment by wrc.drij...@gmail.com on 2 Apr 2013 at 6:09

Attachments:

GoogleCodeExporter commented 8 years ago 
Read this issue, that is why I haven't implemented such patch:

http://code.google.com/p/auto-sub/issues/detail?id=53
It is not as simple as implementing your patch.

Original comment by romke.va...@gmail.com on 5 Apr 2013 at 9:30