Migrate to Dart null safety system

pikaju / flutter-maps-launcher

Simple Flutter package to open the maps application (or browser) on all platforms.

https://pub.dev/packages/maps_launcher

MIT License

61 stars 47 forks source link

Migrate to Dart null safety system #13

Closed orevial closed 3 years ago

orevial commented 3 years ago

Hi,

I propose this pull request to migrate this plugin to null safety as it is the way to go now that Flutter 2 has been released.

Here are the changes I introduced:

Update SDK dependency version to 2.12.0+
Update url_launcher dependency to the new null-safe version
Run dart migrate on existing code, there is almost no change to the codebase as your code was already null-safe, thank you for that 😄 🎉
Fix deprecation warnings
Format codes

Note that it passes Dart static analysis (dart analyze) which means that the package should now get 110/110 pub points on pub.dev 🙂

Thank you for the great work on this plugin and let me know if I can rework something !

orevial commented 3 years ago

Closes #12

hmawla commented 3 years ago

This looks perfect

orevial commented 3 years ago

@pikaju would you mind having a look at this PR and maybe merge it if it seems OK ?

hmawla commented 3 years ago

I can't see changes on the main branch, I am unable to use this package because of dependency error.

This is yet to be merged...

amitkot commented 3 years ago

@hmawla @pikaju can this PR be merged? Thanks!

erperejildo commented 3 years ago

anything blocking this PR?

hmawla commented 3 years ago

I think the repository author is away for the time being. You may create a temporary fix by forking this PR and using it directly in your pubspec.yaml like so:

  maps_launcher :
    git:
      url: https://github.com/{your-username}/flutter-maps-launcher.git
      ref: master

amitkot commented 3 years ago

@hmawla I saw you approved the PR, maybe we could get the author to add you as an additional maintainer?

This is a useful package, I would love for it to stay maintained.

erperejildo commented 3 years ago

Working with in the meantime:

maps_launcher:
    git:
      url: https://github.com/orevial/flutter-maps-launcher.git
      ref: null-safety-migration

mendoxe commented 3 years ago

Any news regarding this topic?

pikaju commented 3 years ago

Damn it, I really need email notifications. Sorry for the wait guys. I will get a new version published ASAP. Thank you for your contribution!