search

pikaju / flutter-maps-launcher

Simple Flutter package to open the maps application (or browser) on all platforms.
https://pub.dev/packages/maps_launcher
MIT License
60 stars 43 forks source link

Update web support for maps_launcher #8

Closed ATeal closed 3 years ago

ATeal commented 3 years ago

@pikaju it seems that web support broke in one of the later versions: https://github.com/pikaju/flutter-maps-launcher/issues/6

I resolved this via flutter create --template=plugin --platforms=web . as described here: https://flutter.dev/docs/development/packages-and-plugins/developing-packages#add-support-for-platforms-in-an-existing-plugin-project

Additionally it looks like web is now requiring a trailing slash, not sure when that got changed.

basel-sader commented 3 years ago

@ATeal where did you run this command? In the plugin directory or the flutter app's directory?

pikaju commented 3 years ago

It seems very odd that this change is necessary. Especially the getPlatformVersion() should not be necessary. Any thoughts?

ATeal commented 3 years ago

@basel-sader I ran it within the plugin directory, I had to do some shenadagins because the plugin name doesn't match the actual git project name if thats causing you any confusion

@pikaju That was part of the generated code so I just left it in there, I can remove and test if you'd like

Edit: Sorry if my comments are delayed only check github so often these days with most of my 9-5 being on gitlab

MattyBoy4444 commented 3 years ago

Please accept!

pikaju commented 3 years ago

I'll merge it for now. @ATeal if you find the time to test it without the extra Dart file, that would be much appreciated.