search

pikax / swgoh

Unofficial node library for swgoh.gg
MIT License
17 stars 4 forks source link

Static resource links are not working #10

Closed Yosi85 closed 6 years ago

Yosi85 commented 6 years ago

So far I've been using your lbirary by setting the img src attributes to the link that is provided for the toons. For example: https://swgoh.gg/static/img/assets/tex.charui_wampa.png This link works in the browser but it doesn't work in the application. I get the following error: swgoh - issue Is there a workaround for this issue? Or alternatively could you pack the static resources (images) to the library so we can reference them locally?

Thanks! And keep up the good work!

Best Regards, Robert

pikax commented 6 years ago

The problem is with the browser, because you are setting the image source directly from swgoh.gg, and it seems it blocks when the referer is not swgoh domain.

I can't include the images in the package, because it will grow the package size.

But I can provide the images from this github repository.

Other solutions would be proxying the images through a service or you store them in a folder and provide them.

If you need a quick workaround you should download or proxy them, because I can only implement it next weekend.

Thank you