pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
103 stars 17 forks source link

Fqsns #295

Closed goodboy closed 2 years ago

goodboy commented 2 years ago

fqsn = "fully qualified symbol name"

Basically the idea here is for all client-ish code (aka programs/actors that ask the provider agnostic layers in the stack for data) should be able to tell which backend / venue / derivative each data feed/flow is from by an explicit string key of the current form <instrumentname>.<venue>.<suffixwithmetadata>.<brokerbackendname>.

I have thoughts that we should actually change this to be more like an "attr lookup" (like how the web should have done urls, but marketting peeps ruined it etc. etc.):

<broker>.<venue>.<instrumentname>.<suffixwithmetadata>

This preps for new derivatives search support in the ib backend coming in #294 (which will get rebased and likely renamed after this).


Moar,

goodboy commented 2 years ago

Bleh, CI is actually failing due to this change:

requirements.txt (line 4))
  Cloning git://github.com/goodboy/tractor.git (to revision master) to ./src/tractor
  Running command git clone --filter=blob:none --quiet git://github.com/goodboy/tractor.git /home/runner/work/piker/piker/src/tractor
  fatal: remote error:
    The unauthenticated git protocol on port 9418 is no longer supported.
  Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

So i guess even more hassle to test things 😂