search

pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
103 stars 17 forks source link

`clearing._messages.BrokerdStatus` should not allow out-of-set statuses.. #297

Open goodboy opened 2 years ago

goodboy commented 2 years ago

We have a wrong comment saying there's an 'executed' status and should further maybe do some validation of the message at creation (though I'd rather wait until we just move to msgspec.Struct).

Main point is a user shouldn't be allowed to create a message that ems doesn't explicitly expect.

iamzoltan commented 2 years ago

sounds good. is this something I should address in the same PR that addresses #296 or make a separate one?